Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

537/ update to connection(s) #566

Merged
merged 1 commit into from
Nov 30, 2021
Merged

537/ update to connection(s) #566

merged 1 commit into from
Nov 30, 2021

Conversation

yayay927
Copy link
Contributor

@yayay927 yayay927 commented Nov 30, 2021 •
edited
Loading

closes #537

Description

Checklist

  • Ran Linting
  • Targeted PR against correct branch.
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote unit tests.
  • Added an entry to the CHANGELOG.md file.
  • Re-reviewed Files changed in the Github PR explorer.

@yayay927 yayay927 requested a review from ryuash November 30, 2021 03:52
@yayay927 yayay927 changed the title update account.json connection(s) 537: update to connection(s) Nov 30, 2021
@yayay927 yayay927 changed the title 537: update to connection(s) 537/ update to connection(s) Nov 30, 2021
@ryuash ryuash merged commit 9c523f0 into base Nov 30, 2021
@ryuash ryuash deleted the 537/base/connections branch November 30, 2021 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryuash ryuash ryuash approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Base: change connections into connection(s)
2 participants
@yayay927 @ryuash