Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add: changelog #811

Merged
merged 1 commit into from
Apr 14, 2022
Merged

add: changelog #811

merged 1 commit into from
Apr 14, 2022

Conversation

ryuash
Copy link
Contributor

@ryuash ryuash commented Apr 13, 2022

Description

closes #810

@kwunyeung @RiccardoM Can you guys confirm this calculates the apr correctly with the community tax taken in to consideration?

// total_supply * ((1 - community_tax) * inflation) / bonded
const inflationWithCommunityTax = Big(1).minus(communityTax).times(inflation).toPrecision(2); 
const apr = Big(rawSupplyAmount).times(inflationWithCommunityTax).div(bondedTokens).toNumber();

Checklist

  • Ran Linting
  • Targeted PR against correct branch.
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote unit tests.
  • Added an entry to the CHANGELOG.md file.
  • Re-reviewed Files changed in the Github PR explorer.

@ryuash ryuash marked this pull request as ready for review April 14, 2022 13:40
@ryuash ryuash merged commit 1080291 into base Apr 14, 2022
@ryuash ryuash deleted the 810/fix-apr-calculation branch April 14, 2022 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

APR calculation | community tax
1 participant