The bdjuno doesn't cover the proposal status change from the deposit to voting. #680
Assignees
Comments
16 tasks
dzmitryhil
changed the title
MonikaCat
added a commit
that referenced
this issue
Feb 5, 2024
…681) ## Description Currently the bdjuno doesn't cover the proposal status change from the deposit to voting. If a user creates a proposal with a minimum deposit the proposal has the status `deposit`. Later if a user adds more deposit to activate voting, the bdjuno doesn't change the proposals's state, and it remains `deposit`, however, the correct state is voting. The PR contains changes to update the state of the proposal if the block tx events contain proper events. Cosmos SDK ref: https://github.com/cosmos/cosmos-sdk/blob/release/v0.47.x/x/gov/keeper/msg_server.go#L182 Resolves: #680 <!-- Add a description of the changes that this PR introduces and the files that are the most critical to review. --> --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [x] added `!` to the type prefix if API or client breaking change - [x] targeted the correct branch - [x] provided a link to the relevant issue or specification - [x] added a changelog entry to `CHANGELOG.md` - [x] included comments for [documenting Go code](https://blog.golang.org/godoc) - [x] updated the relevant documentation or specification - [x] reviewed "Files changed" and left comments if necessary - [x] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable) --------- Co-authored-by: Magic Cat <37407870+MonikaCat@users.noreply.github.com>
MonikaCat
added a commit
that referenced
this issue
Feb 5, 2024
…681) Currently the bdjuno doesn't cover the proposal status change from the deposit to voting. If a user creates a proposal with a minimum deposit the proposal has the status `deposit`. Later if a user adds more deposit to activate voting, the bdjuno doesn't change the proposals's state, and it remains `deposit`, however, the correct state is voting. The PR contains changes to update the state of the proposal if the block tx events contain proper events. Cosmos SDK ref: https://github.com/cosmos/cosmos-sdk/blob/release/v0.47.x/x/gov/keeper/msg_server.go#L182 Resolves: #680 <!-- Add a description of the changes that this PR introduces and the files that are the most critical to review. --> --- *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [x] added `!` to the type prefix if API or client breaking change - [x] targeted the correct branch - [x] provided a link to the relevant issue or specification - [x] added a changelog entry to `CHANGELOG.md` - [x] included comments for [documenting Go code](https://blog.golang.org/godoc) - [x] updated the relevant documentation or specification - [x] reviewed "Files changed" and left comments if necessary - [x] confirmed all CI checks have passed *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable) --------- Co-authored-by: Magic Cat <37407870+MonikaCat@users.noreply.github.com>
MonikaCat
added a commit
that referenced
this issue
Feb 5, 2024
…681) Currently the bdjuno doesn't cover the proposal status change from the deposit to voting. If a user creates a proposal with a minimum deposit the proposal has the status `deposit`. Later if a user adds more deposit to activate voting, the bdjuno doesn't change the proposals's state, and it remains `deposit`, however, the correct state is voting. The PR contains changes to update the state of the proposal if the block tx events contain proper events. Cosmos SDK ref: https://github.com/cosmos/cosmos-sdk/blob/release/v0.47.x/x/gov/keeper/msg_server.go#L182 Resolves: #680 <!-- Add a description of the changes that this PR introduces and the files that are the most critical to review. --> --- *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [x] added `!` to the type prefix if API or client breaking change - [x] targeted the correct branch - [x] provided a link to the relevant issue or specification - [x] added a changelog entry to `CHANGELOG.md` - [x] included comments for [documenting Go code](https://blog.golang.org/godoc) - [x] updated the relevant documentation or specification - [x] reviewed "Files changed" and left comments if necessary - [x] confirmed all CI checks have passed *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable) --------- Co-authored-by: Magic Cat <37407870+MonikaCat@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bug description
The bdjuno doesn't cover the proposal status change from the deposit to voting.
Steps to reproduce
If a user creates a proposal with a minimum deposit the proposal has the status
deposit. Later if a user adds more deposit to activate voting, the bdjuno doesn't change the proposals's state, and it remainsdeposit, however, the correct state is voting. The PR contains changes to update the state of the proposal if the block tx events contain proper events.Expected behavior
The status should be changed from deposit to voting, once it is change on the node level.
PR with the fix: #681
The text was updated successfully, but these errors were encountered: