Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: BondedTokens exceeds int64 range #300

Merged

Conversation

huichiaotsou
Copy link
Contributor

@huichiaotsou huichiaotsou commented Jan 1, 2022

Description

Closes: #XXXX

fix bonded tokens / unbonded tokens exceeding range with int64.
Store the value as string instead.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (v2/cosmos/stargate@1bdca6c). Click here to learn what that means.
The diff coverage is n/a.

@@                  Coverage Diff                  @@
##             v2/cosmos/stargate     #300   +/-   ##
=====================================================
  Coverage                      ?   50.58%           
=====================================================
  Files                         ?       19           
  Lines                         ?     1870           
  Branches                      ?        0           
=====================================================
  Hits                          ?      946           
  Misses                        ?      796           
  Partials                      ?      128           

@MonikaCat
Copy link
Contributor

@huichiaotsou Can you also update the schema for proposal_staking_pool_snapshot table ?

@huichiaotsou
Copy link
Contributor Author

@huichiaotsou Can you also update the schema for proposal_staking_pool_snapshot table ?

Hi hi @MonikaCat I found out that the type we use in staking_pool table is also BIGINT, should I update both or we can keep BIGINT for both tables?

@MonikaCat
Copy link
Contributor

@huichiaotsou Yes let's update the staking_pool table to TEXT type as well, coz on some chains this value might also be too large to store as a BIGINT

@MonikaCat MonikaCat added the automerge Automatically merge PR once all prerequisites pass label Jan 5, 2022
Copy link
Contributor

@MonikaCat MonikaCat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@RiccardoM RiccardoM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@mergify mergify bot merged commit 210e7a1 into v2/cosmos/stargate Jan 6, 2022
@mergify mergify bot deleted the aaron/proposal_staking_pool_store_string branch January 6, 2022 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Automatically merge PR once all prerequisites pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants