Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [cheqd] add parse cmd to top accounts module #511

Merged
merged 15 commits into from
Feb 3, 2023
Merged

feat: [cheqd] add parse cmd to top accounts module #511

merged 15 commits into from
Feb 3, 2023

Conversation

huichiaotsou
Copy link
Contributor

@huichiaotsou huichiaotsou commented Dec 27, 2022 •
edited
Loading

Description

Closes: #XXXX

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (chains/cheqd/mainnet@2c75a27). Click here to learn what that means.
The diff coverage is n/a.

@@                   Coverage Diff                   @@
##             chains/cheqd/mainnet     #511   +/-   ##
=======================================================
  Coverage                        ?   58.06%           
=======================================================
  Files                           ?       20           
  Lines                           ?     1495           
  Branches                        ?        0           
=======================================================
  Hits                            ?      868           
  Misses                          ?      522           
  Partials                        ?      105

@huichiaotsou huichiaotsou changed the title feat: [cheqd] add parse cmd to top accounts module with workers feat: [cheqd] add parse cmd to top accounts modul Dec 27, 2022
@huichiaotsou huichiaotsou marked this pull request as ready for review December 27, 2022 10:39
@huichiaotsou huichiaotsou marked this pull request as draft December 27, 2022 10:40
@huichiaotsou huichiaotsou removed the request for review from MonikaCat December 27, 2022 10:40
@huichiaotsou huichiaotsou changed the title feat: [cheqd] add parse cmd to top accounts modul feat: [cheqd] add parse cmd to top accounts module Dec 29, 2022
@huichiaotsou huichiaotsou marked this pull request as ready for review December 29, 2022 15:24
@MonikaCat MonikaCat added the automerge Automatically merge PR once all prerequisites pass label Feb 3, 2023
MonikaCat
MonikaCat approved these changes Feb 3, 2023
View reviewed changes
Copy link
Contributor

@MonikaCat MonikaCat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested, LGTM

@mergify mergify bot merged commit 86a1835 into chains/cheqd/mainnet Feb 3, 2023
@mergify mergify bot deleted the aaron/cheqd/parse_cmd_top_accounts branch February 3, 2023 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RiccardoM RiccardoM RiccardoM approved these changes

@MonikaCat MonikaCat MonikaCat approved these changes

Assignees
No one assigned
Labels
automerge Automatically merge PR once all prerequisites pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@huichiaotsou @codecov-commenter @RiccardoM @MonikaCat