feat: add ChainID() method for getting the chain ID from node status #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MonikaCat
approved these changes
Jul 5, 2022
RiccardoM
approved these changes
Jul 5, 2022
RiccardoM
pushed a commit
that referenced
this pull request
Jul 27, 2022
…69) ## Description For getting `chain ID`, replace `querying genesis` with `querying status` as `querying genesis` is heavy and may put much load on the node which is unnecessary, especially when the app crashed and restarted. ## Checklist - [ ] Targeted PR against correct branch. - [ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work. - [ ] Wrote unit tests. - [ ] Re-reviewed `Files changed` in the Github PR explorer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For getting
chain ID, replacequerying genesiswithquerying statusasquerying genesisis heavy and may put much load on the node which is unnecessary, especially when the app crashed and restarted.Checklist
Files changedin the Github PR explorer.