Log UA marker only if browser auth completed #1991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khawkins
reviewed
Apr 12, 2017
| @@ -315,26 +313,23 @@ - (BOOL)handleAdvancedAuthenticationResponse:(NSURL *)appUrlResponse { | |||
| [self log:SFLogLevelInfo format:@"%@ Current advanced auth state (%@) not compatible with handling app launch auth response.", NSStringFromSelector(_cmd), [[self class] advancedAuthStateDesc:self.advancedAuthState]]; | |||
| return NO; | |||
| } | |||
|
|
|||
| [SFSDKAppFeatureMarkers registerAppFeature:kSFAppFeatureSafariBrowserForLogin]; | |||
There was a problem hiding this comment.
Do you want this where the advanced browser flow has actually fully completed? This isn't quite there.
There was a problem hiding this comment.
No - only when the browser portion is complete. This is good enough.
wmathurin
approved these changes
Apr 12, 2017
Current coverage for SalesforceSDKCore.framework is
|
| Files changed | - | - |
|---|---|---|
| SFSDKNewLoginHostViewController.m | 0% |
💀 |
| SFOAuthCoordinator.m | 32% |
🚫 |
Current coverage for SalesforceAnalytics.framework is 41%
✅ No files affecting coverage found
Powered by xcov
Generated by 🚫 Danger
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.