Skip to content
This repository has been archived by the owner on Mar 23, 2024. It is now read-only.

feat: PRCE-compliant RegEx updates for GitHub Linguist #54

Closed
wants to merge 11 commits into from

Conversation

muenzpraeger
Copy link
Contributor

This PR updates certain RegEx elements to be PCRE RegEx compliant (specifically: changing - to _ in named capture group identifiers).

The change is in this commit.

This is needed so that we can get the tmLanguage definition into GitHub's Linguist for language detection and syntax highlighting.

The other changes outside of the above linked commit are either dependency updates or reformatting of files (b/c of changed Prettier behavior).

@randi274 randi274 requested review from a team and CristiCanizales and removed request for CristiCanizales December 5, 2022 21:19
@randi274
Copy link
Contributor

randi274 commented Dec 5, 2022

Hi @muenzpraeger - we're going through open contributions this week to review, and I've added this one to our list! The caveat on this one is our github actions still need to be configured for this repo, so it may take some extra time for us to get out and published. Is this working against any sort of time crunch we should be aware of?

@muenzpraeger
Copy link
Contributor Author

No time crunch. Let me know if I can help out.

There will likely be a few more PRs in the next time, as I discovered a few others non-matches. But not this week, I guess. ;-)

@randi274
Copy link
Contributor

Hey @muenzpraeger - good news! I was able to get our CI/CD back up and running for this repo last week, so we're one step closer to getting this in! I've got this change running against our automated builds with #57. For testing purposes, are you expecting any functionality changes from this PR, or is it mainly to support a compliance update to Github Linguist?

@muenzpraeger
Copy link
Contributor Author

@randi274 No functional changes beyond what's listed in the initial PR comment.

You can eventually expect a few more PRs soon, as I discovered a few language discrepancies/missing keywords. But not today or tomorrow. ;-)

@randi274
Copy link
Contributor

randi274 commented Feb 23, 2023

Hey @muenzpraeger we're coming back around to this one today - I left a few questions on our internal PR to see if you've got thoughts based on team review.

@randi274
Copy link
Contributor

Thanks for your patience on this @muenzpraeger! We were finally able to come back to this post-TDX and this has now been published with #57.

@randi274 randi274 closed this Mar 15, 2023
@muenzpraeger
Copy link
Contributor Author

Wooohooot! Thank you so much!

@muenzpraeger muenzpraeger deleted the rw/regex-updates branch March 15, 2023 19:39
@dschach
Copy link

dschach commented Mar 16, 2023

Thank you all for working on this. I'm trying to get highlightjs-apex updated, and this file helps a lot in writing that highlighter (which works for html).

If anyone has advice on tools to make the process easier, I'm all ears, but this is a VERY complex file and has some circular dependencies that work in this kind of file but not in highlight.js.

@muenzpraeger
Copy link
Contributor Author

@dschach Use Shiki - that's what I am aiming for (disclaimer: I'm a contributor there too). Utilizing and enhancing our language experiences across IDE'a and web.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants