Remove empty failure tag on successful test execution

[roftone]

Is your feature request related to a problem? Please describe.
Yes, new deployment commands seems to have changed the junit xml format. Before, an empty failure tag was not present on the returned xml.

What are you trying to do
Run a mock deployment on a gitlab merge request.

Describe the solution you'd like
Not have the test results be considered a failure.

Describe alternatives you've considered
Reverting to the previous sfdx commands.

Additional context

Before:

After:

[github-actions]

Thank you for filing this feature request. We appreciate your feedback and will review the feature at our next grooming or sprint planning session. We prioritize feature requests with more upvotes and comments.

[git2gus]

This issue has been linked to a new work item: W-13048665

[WillieRuemmele]

Hey @roftone 👋 thanks for reporting this,

can you provide some more information such as CLI version and command with flags that you're running, when did you first notice this change?

[roftone]

Yes,

sfdx-cli 7.196.8 (core)

The command is:
sfdx project deploy start $packageParams $postDestructiveParams --dry-run --wait 3600 --verbose --junit --results-dir ./tests/apex -l RunLocalTests --coverage-formatters json

I had tested the new commands locally and everything seemed fine. It was only today, when I pushed the pipeline change, that I noticed the change in the merge request test results and compared the generated junit files.

[WillieRuemmele]

great, and does it work correctly if you use sfdx force source deploy?

[WillieRuemmele]

^ more of a bug, but the WI has already been created

[roftone]

great, and does it work correctly if you use sfdx force source deploy?

Yes, that's the command that we are using again.

[R0Wi]

salesforcecli/plugin-deploy-retrieve#610 should fix this. Cheers.

[roftone]

salesforcecli/plugin-deploy-retrieve#610 should fix this. Cheers.

Awesome, I'll test it as soon as it goes live.

[WillieRuemmele]

Thanks @R0Wi for the contribution 🏆

I just merged this into plugin-deploy-retrieve which will be available in tonight's nightly build of the CLIs 🎉

[R0Wi]

Just tested the current nightly (https://developer.salesforce.com/media/salesforce-cli/sfdx/versions/7.202.3/8fc437b/sfdx-v7.202.3-8fc437b-linux-x64.tar.xz) and the error seems to be gone.

[roftone]

@R0Wi
Just tested the fix, works great. Thanks.