feat: add elapsed time decorator to apex node class methods #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test/tests/asyncTests.test.ts
Outdated
There was a problem hiding this comment.
why are pretty much all of these tests removed?
|
nit: is the WI in the description the right one? |
Not really, I can create another and update the PR |
@CristiCanizales corrected work item. |
gbockus-sf
reviewed
Feb 28, 2024
src/utils/elapsedTime.ts
Outdated
| import { Logger, LoggerLevel } from '@salesforce/core'; | ||
| import { LoggerLevelValue } from '@salesforce/core/lib/logger/logger'; | ||
|
|
||
| const logThis = ( |
There was a problem hiding this comment.
nit: this always makes for confusion in a js/ts world. Maybe just call this log? I could see this getting exported for use as need across the module. (doesn't have to be now, just when needed.)
gbockus-sf
reviewed
Feb 28, 2024
mingxuanzhangsfdx
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add detailed elapsed time debug log data for most of the class methods in this module.
The log records are typically enabled using debug log level, with a few methods that do a lot of string manipulation and tagged with debug log level trace.
This is an investigative step in trying to diagnose customer reported delays in commands not finishing (actually hanging) after the command in question has finished rendering the results, or commands that are taking an inordinately log time to run, such as test runs in a few seconds but command take 35 minutes to complete.
@W-15130974@
There should be no perceived change in running commands, however with log level set to debug or trace, the CLI log files will include elapsed time data gathered during command execution