Causes PHP Syntax Highlighting Issue

[westc]

Summary

When this extension is enabled in Visual Studio Code the native syntax highlighting for PHP doesn't highlight other embedded languages (HTML, CSS and JavaScript) as expected.

Steps To Reproduce:

1. Enable this extension.
2. Create a new file tab.
3. Set the language to PHP.
4. Enter the following code:

   <?php if (true): ?>
     <div>Hello world!!!</div>
     <script type="text/javascript">
     var x = 3;
     document.write(x);
     </script>
     <style type="text/css">
     div {
       color: #00F;
     }
     </style>
   <?php endif; ?>

Expected result

All of the code will be syntax highlighted depending on the language:

Actual result

The PHP code will be highlighted as PHP but the inline HTML, CSS and JS will not be highlighted:

Additional information

VS Code Version: 1.42.1

SFDX CLI Version: sfdx-cli/7.36.0-b1c4e9c7c8 darwin-x64 node-v10.15.3

OS and version: macOS Mojave 10.14.6

OS According to VS Code: Darwin x64 18.7.0

[lcampos]

Thanks for reporting this @westc , we've made changes in release 48.6.0 to make sure the extensions are only active in Salesforce projects which will take care of this.

[xyc]

Looks like this is related to html language contribution. While "Aura Components" extension is enabled (even if not activated) this issue would present. @mysticflute @nrkruk could we continue conversation here WRT modification for aura support?

[ntotten]

@lcampos Is it even possible to disable the language contribution of an extension without deactivating it entirely?

[jeffb-sfdc]

I'm still able to reproduce this.

[uip-robot-zz]

This issue has been linked to a new work item: W-10934996

[michaelsoriano]

This is still happening. Messing up HTML color syntax in PHP files.

I'm using VSCode 1.72 + SF Extension Pack v v55.8.0.
It immediately gets fixed as soon as I disable the SF Extension pack. Shouldn't it disable automatically in non SF projects? Or is there a setting I have to turn on?

[randi274]

Hi @michaelsoriano just to check for your case as well - is this happening in unsaved php files, or files that are saved with the .php extension?

[michaelsoriano]

Hi @randi274 - its both. For saved .php files and new files (no extension). Here's a screenshot of both side by side:

[randi274]

@michaelsoriano we actually do have a setting for this! It's possible it's not being respected now, but we would recommend using "Autodetect" in your case, or using "off" definitively should stop the LWC and Aura Language Servers from activating.

[michaelsoriano]

@randi274 thank you. I checked the settings and "autodetect" is already on.

I've learned to just manually "disable" the entire extension pack in PHP projects.

[gbockus-sf]

PR merged. Will be included with next release #5159