fix: update aura html grammar scope #5159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbockus-sf
commented
Oct 17, 2023
| @@ -116,7 +116,7 @@ | |||
| "grammars": [ | |||
| { | |||
| "language": "html", | |||
| "scopeName": "text.html.basic", | |||
| "scopeName": "aura.html", | |||
There was a problem hiding this comment.
By making this name have 2 parts instead of 3 it keeps it from overriding the styles incorrectly for php html.
gbockus-sf
requested review from
daphne-sfdc
and removed request for
randi274
daphne-sfdc
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The html grammar in the Aura extension had a three part name that forced it to take precedence when looking at html associated files. (text.html.basic). This has been reported as an issue a couple of times for php which has an html grammar scope of (html.php).
I altered the scope name to be simpler (aura.html) and now php html files are correctly parsed and visually marked up by the php grammar file.
What issues does this PR fix or reference?
@W-10934996@
#5154
#1988
Functionality Before
Functionality After
Aura html file still works properly
php files also works properly
