Update telemetry for dirType on command events #1224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lcampos
requested review from
brpowell,
AnanyaJha,
allileong,
JimSuplizio,
praksb,
sfsholden and
ntotten
lcampos
commented
Apr 2, 2019
| private getEndHRTime(hrstart: [number, number]): string { | ||
| const hrend = process.hrtime(hrstart); | ||
| return util.format('%ds %dms', hrend[0], hrend[1] / 1000000); | ||
| return util.format('%d%d', hrend[0], hrend[1] / 1000000); |
There was a problem hiding this comment.
Update time format from 0s 6789ms to 06789
lcampos
commented
Apr 2, 2019
| @@ -15,6 +15,12 @@ import TelemetryReporter from './telemetryReporter'; | |||
| const TELEMETRY_GLOBAL_VALUE = 'sfdxTelemetryMessage'; | |||
| const EXTENSION_NAME = 'salesforcedx-vscode-core'; | |||
|
|
|||
| interface CommandMetric { | |||
There was a problem hiding this comment.
Basic metric data interface for command execution.
lcampos
commented
Apr 2, 2019
| @@ -127,20 +133,25 @@ export class TelemetryService { | |||
|
|
|||
| public sendCommandEvent( | |||
| commandName?: string, | |||
| hrstart?: [number, number] | |||
| hrstart?: [number, number], | |||
| additionalData?: any | |||
There was a problem hiding this comment.
Doing it this way allows us to expand metrics on command execution without touching the interface that often.
lcampos
commented
Apr 2, 2019
| @@ -202,5 +202,33 @@ describe('Telemetry', () => { | |||
| }; | |||
| assert.calledWith(reporter, 'commandExecution', match(expectedData)); | |||
| }); | |||
|
|
|||
| it('Should send correct data format on sendCommandEvent with additionalData', async () => { | |||
There was a problem hiding this comment.
New test for optional additionalData param
lcampos
commented
Apr 2, 2019
| @@ -83,18 +83,8 @@ export class TelemetryService { | |||
| } | |||
| } | |||
|
|
|||
| public async sendCommandEvent(commandName?: string): Promise<void> { | |||
There was a problem hiding this comment.
Removing since it's not used anymore.
allileong
approved these changes
Apr 2, 2019
Codecov Report
@@ Coverage Diff @@
## develop #1224 +/- ##
========================================
Coverage 71.01% 71.01%
========================================
Files 196 196
Lines 7397 7397
Branches 781 781
========================================
Hits 5253 5253
Misses 1989 1989
Partials 155 155
Continue to review full report at Codecov.
|
lcampos
added a commit
that referenced
this pull request
Apr 3, 2019
lcampos
added a commit
that referenced
this pull request
Apr 3, 2019
This was referenced Jan 22, 2022
This was referenced Oct 6, 2022
This was referenced Nov 5, 2022
This was referenced Dec 26, 2022
This was referenced Jun 20, 2023
This was referenced Nov 28, 2023
This was referenced May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Updates metrics for command execution so that command name is not mixed with directory type. Also updates execution time format for all metrics.
What issues does this PR fix or reference?
@W-6007844@