Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default project create template to standard #1234

Closed
wants to merge 1 commit into from

Conversation

ntotten
Copy link
Contributor

@ntotten ntotten commented Apr 5, 2019

What does this PR do?

Updates the project create to use the standard template

What issues does this PR fix or reference?

#1090

@ntotten ntotten requested a review from lcampos April 5, 2019 18:44
@ruthemmanuelle
Copy link
Contributor

ruthemmanuelle commented Apr 5, 2019

Thanks for updating this, @ntotten . The Salesforce release notes will say that the standard template becomes the default (in Salesforce CLI and Salesforce Extensions for VS Code) at R2. I think we should wait until then to merge this PR. We have docs and Trailhead content that refer to the old project structure, and they'll be wrong if we merge this now. Cc: @lcampos

Edit: We do want to make --template standard the default now in the pre-release version of the CLI, though.

@ntotten
Copy link
Contributor Author

ntotten commented Apr 5, 2019

I don't want to wait in VS Code. This isn't going to break documentation or tutorials because the commands don't change, the only difference is that the template will have more stuff in it. The reason we are waiting in CLI is that the change of the default template is breaking and we only introduce breaking changes in the CLI at R2. This is not considered a breaking change in VS Code.

Let's update the release notes to reflect that the change is only the default in CLI at R2.

@ruthemmanuelle
Copy link
Contributor

Here are a couple of Trailhead units that will be wrong if we merge this:

There might be others. Those are just the ones I know about off the top of my head.

@lcampos
Copy link
Contributor

lcampos commented Apr 24, 2019

Changes merged as PR #1283

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants