Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update LSP jar for NPE that happens during computing references #1245

Merged
merged 1 commit into from
Apr 8, 2019

Conversation

praksb
Copy link
Contributor

@praksb praksb commented Apr 8, 2019

What does this PR do?

Updates LSP jar with the latest LSP changes.

What issues does this PR fix or reference?

Fixes an NPE that was being caused by adding references to type/member which are null during computing of references.
@W-6022740@

@codecov
Copy link

codecov bot commented Apr 8, 2019

Codecov Report

Merging #1245 into develop will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1245      +/-   ##
===========================================
- Coverage       71%   70.97%   -0.03%     
===========================================
  Files          196      196              
  Lines         7397     7397              
  Branches       781      781              
===========================================
- Hits          5252     5250       -2     
- Misses        1989     1990       +1     
- Partials       156      157       +1
Impacted Files Coverage Δ
...edx-vscode-core/src/telemetry/telemetryReporter.ts 50.7% <0%> (-2.82%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9857e8f...f17dbff. Read the comment docs.

Copy link
Contributor

@lcampos lcampos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know if you need help merging this given the current test failure caused by vscode 1.33

@praksb
Copy link
Contributor Author

praksb commented Apr 8, 2019

@lcampos Can you please help merge? The test failure is not letting me to merge.

@lcampos lcampos merged commit c57ecf3 into develop Apr 8, 2019
@lcampos lcampos deleted the lspjar branch April 8, 2019 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants