Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activate test execution on Travis CI #16

Merged
merged 4 commits into from Jul 27, 2017
Merged

Activate test execution on Travis CI #16

merged 4 commits into from Jul 27, 2017

Conversation

guw
Copy link
Contributor

@guw guw commented Jul 26, 2017

This installs latest SFDX CLI and runs tests on Travis CI.

Note, the build time increases due to the use of "sudo: required" for installing the SFDX CLI. Running the tests also adds to the overall build time.

@W-4092803@

.travis.yml Outdated
@@ -1,6 +1,6 @@
language: node_js

sudo: false
sudo: required

node_js:
- "6"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use node 7? VS Code uses node v7.4.0

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.

@vazexqi
Copy link
Contributor

vazexqi commented Jul 26, 2017

@guw Woah it's really much slower on the Mac version. Linux takes 4 minutes but the Mac takes 10. And since we don't get concurrent builds on the free Travis that is going to be about 14 minutes.
Let's see how long Appveyor takes so that we can compare.

For comparison, locally it takes about 1 minute to run.

@vazexqi
Copy link
Contributor

vazexqi commented Jul 26, 2017

Slow OS X builds seem to be a known issue: travis-ci/travis-ci#7304

@guw
Copy link
Contributor Author

guw commented Jul 26, 2017

@vazexqi FWIW, if may be possible to disable OSX builds for topic branches and pull requests and only have it running on develop and master. It would be a trade-off for faster cycle time.

Copy link
Contributor

@vazexqi vazexqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@guw guw merged commit 59560a2 into develop Jul 27, 2017
@guw guw deleted the gunnar/travis branch July 27, 2017 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants