Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DONT MERGE YET: Trying to restore the telemetry tests. #1974

Closed
wants to merge 2 commits into from

Conversation

KrisGraySFDC
Copy link
Contributor

What does this PR do?

Brings back the Telemetry tests which were causing the whole suite to not run.

What issues does this PR fix or reference?

@W-7171718@

Functionality Before

Tests were commented out.

Functionality After

All I've done so far is uncomment the tests, need to figure out why they are failing the runs.

@KrisGraySFDC KrisGraySFDC changed the title Trying to restore the telemetry tests. DONT MERGE YET: Trying to restore the telemetry tests. Feb 13, 2020
@codecov
Copy link

codecov bot commented Feb 13, 2020

Codecov Report

Merging #1974 into develop will increase coverage by 8.92%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1974      +/-   ##
===========================================
+ Coverage    75.03%   83.96%   +8.92%     
===========================================
  Files          228       69     -159     
  Lines         8440     3099    -5341     
  Branches       937      294     -643     
===========================================
- Hits          6333     2602    -3731     
+ Misses        1868      439    -1429     
+ Partials       239       58     -181
Impacted Files Coverage Δ
...forcedx-apex-replay-debugger/src/messages/index.ts 41.66% <0%> (-8.34%) ⬇️
...scode-lwc/src/testSupport/testRunner/testRunner.ts
...rcedx-vscode-lwc/src/testSupport/commands/index.ts
...ges/salesforcedx-vscode-core/src/conflict/index.ts
.../src/commands/templates/forceLightningAppCreate.ts
...testSupport/commands/forceLwcTestNavigateToTest.ts
...rc/testSupport/commands/forceLwcTestWatchAction.ts
...lesforcedx-vscode-lwc/src/commands/commandUtils.ts
...rc/testSupport/testExplorer/testOutlineProvider.ts
...ore/src/commands/templates/internalCommandUtils.ts
... and 150 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ae8d48...4f29ac2. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant