Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename jp to ja #1983

Merged
merged 3 commits into from
Feb 15, 2020
Merged

Rename jp to ja #1983

merged 3 commits into from
Feb 15, 2020

Conversation

ntotten
Copy link
Contributor

@ntotten ntotten commented Feb 14, 2020

What does this PR do?

Renames the localization folder jp to use the correct localization string ja

What issues does this PR fix or reference?

@W-7227338@

@codecov
Copy link

codecov bot commented Feb 14, 2020

Codecov Report

Merging #1983 into develop will increase coverage by 10.79%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           develop    #1983       +/-   ##
============================================
+ Coverage    73.17%   83.96%   +10.79%     
============================================
  Files          232       69      -163     
  Lines         8651     3099     -5552     
  Branches       987      294      -693     
============================================
- Hits          6330     2602     -3728     
+ Misses        2083      439     -1644     
+ Partials       238       58      -180
Impacted Files Coverage Δ
...forcedx-apex-replay-debugger/src/messages/index.ts 41.66% <0%> (-8.34%) ⬇️
...scode-lwc/src/testSupport/testRunner/testRunner.ts
...rcedx-vscode-lwc/src/testSupport/commands/index.ts
...ges/salesforcedx-vscode-core/src/conflict/index.ts
.../src/commands/templates/forceLightningAppCreate.ts
...testSupport/commands/forceLwcTestNavigateToTest.ts
...rc/testSupport/commands/forceLwcTestWatchAction.ts
...lesforcedx-vscode-lwc/src/commands/commandUtils.ts
...rc/testSupport/testExplorer/testOutlineProvider.ts
...ore/src/commands/templates/internalCommandUtils.ts
... and 154 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 306f45a...042d954. Read the comment docs.

Copy link
Contributor

@lcampos lcampos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I'll take care of merging this once I solve some merge conflicts

@lcampos lcampos self-assigned this Feb 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants