Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken write-aura doc links #1987

Merged
merged 3 commits into from
Feb 14, 2020
Merged

Conversation

lcampos
Copy link
Contributor

@lcampos lcampos commented Feb 14, 2020

What does this PR do?

Fixes sidebar and article aura links that are broke

What issues does this PR fix or reference?

@W-7226967@

@codecov
Copy link

codecov bot commented Feb 14, 2020

Codecov Report

Merging #1987 into release/v48.1.0 will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                 @@
##           release/v48.1.0   #1987      +/-   ##
==================================================
+ Coverage            74.99%     75%   +0.01%     
==================================================
  Files                  225     225              
  Lines                 8283    8283              
  Branches               922     922              
==================================================
+ Hits                  6212    6213       +1     
  Misses                1838    1838              
+ Partials               233     232       -1
Impacted Files Coverage Δ
...forcedx-vscode-core/src/channels/channelService.ts 85.71% <0%> (+2.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ba6178...ae77f0d. Read the comment docs.

@lcampos lcampos merged commit 0d2d46a into release/v48.1.0 Feb 14, 2020
@lcampos lcampos deleted the lcampos/aura-broken-links branch February 14, 2020 22:33
@AnanyaJha
Copy link
Collaborator

The numbering for the suggestions underQuick Fix: Declare Missing Methods is off, but links seem fine!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants