Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More apex snippets #2262

Closed
wants to merge 9 commits into from

Conversation

lukecotter
Copy link
Contributor

What does this PR do?

Adds more snippets for apex.
Improves existing for loop snippets by adding type to the loop variable.
Improves existing while loop snippets by replacing true default value with condition.

What issues does this PR fix or reference?

#2261

@lukecotter lukecotter requested a review from a team as a code owner June 12, 2020 22:35
@salesforce-cla
Copy link

Thanks for the contribution! Unfortunately we can't verify the commit author(s): Luke Cotter <l***@f***.com>. One possible solution is to add that email to your GitHub account. Alternatively you can change your commits to another email and force push the change. After getting your commits associated with your GitHub account, sign the Salesforce.com Contributor License Agreement and this Pull Request will be revalidated.

@ntotten
Copy link
Contributor

ntotten commented Jun 12, 2020

This is great, thanks for sending! Please sign the CLA and we’ll merge right away.

- Separated the type from the variable.
- In the case of the soql loop the type will default to SObject.
Default condition value is now 'condition' instead of 'true'.
This should be more descriptive and will prevent the edge case
of the default not being chnaged and an infinte loop occuring.
- ifelse, ifnull, ifnotnull and ter (ternary).
- System.assert(false, message);
- System.assertEqual(expected, actual);
- System.assertNotEqual(expected, actual);
- System.assertEqual(null, actual):
- System.assertNotEqual(null, actual):
- New constructor, New Object, Field, New Method, New Static Method.
@salesforce-cla
Copy link

Thanks for the contribution! Before we can merge this, we need @lukecotter to sign the Salesforce.com Contributor License Agreement.

@lukecotter
Copy link
Contributor Author

lukecotter commented Jun 15, 2020

This is great, thanks for sending! Please sign the CLA and we’ll merge right away.

Sure will do. When signing do I use my primary email or can I use the private noreply email?

@lcampos
Copy link
Contributor

lcampos commented Jun 16, 2020

@lukecotter for signing the CLA you need to use the same address used in the commits.

@lukecotter
Copy link
Contributor Author

All done

@lcampos
Copy link
Contributor

lcampos commented Jun 30, 2020

@lukecotter I'm closing this PR since we merged your changes as part of #2301 and they will be released later this week in version 48.23.0 of the extensions. Thanks for your contributions to the project.

@lcampos lcampos closed this Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants