Lf/retrieve and open doesnt handle types with xml only files #2635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #2635 +/- ##
===========================================
- Coverage 76.48% 76.47% -0.02%
===========================================
Files 300 300
Lines 10725 10732 +7
Branches 1191 1191
===========================================
+ Hits 8203 8207 +4
- Misses 2199 2202 +3
Partials 323 323
Continue to review full report at Codecov.
|
lcampos
reviewed
Oct 15, 2020
| } | ||
| } else { |
There was a problem hiding this comment.
Do we have any tests covering this ?
…with-xml-only-files
…with-xml-only-files
lcampos
deleted the
lf/Retrieve-and-open-doesnt-handle-types-with-xml-only-files
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When the 'Retrieve and open' feature is performed and there is no file extension defined, it opens the '-meta.xml' file by default.
What issues does this PR fix or reference?
@W-8193920@
Functionality Before
When there wasn't a definition on MetadataDictionary the feature didn't open any file
Functionality After
When there isn't a definition on MetadataDictionary, the feature opens '-meta.xml' file by default.