fix: diagnostics not clearing for apex execute #2673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brpowell
commented
Oct 27, 2020
| @@ -135,7 +135,7 @@ export class ApexLibraryExecuteExecutor extends LibraryCommandletExecutor<ApexEx | |||
| protected executionName = nls.localize('apex_execute_text'); | |||
| protected logName = 'force_apex_execute_library'; | |||
|
|
|||
| private diagnostics = vscode.languages.createDiagnosticCollection( | |||
| public static diagnostics = vscode.languages.createDiagnosticCollection( | |||
There was a problem hiding this comment.
Creating new instances of the diagnostics collection was the problem.
brpowell
commented
Oct 27, 2020
|
|
||
| handleApexLibraryDiagnostics(result, this.diagnostics, filePath); | ||
| } | ||
| handleApexLibraryDiagnostics(result, ApexLibraryExecuteExecutor.diagnostics, filePath); |
There was a problem hiding this comment.
This handles clearing the collection if needed.
Codecov Report
@@ Coverage Diff @@
## release/v50.3.0 #2673 +/- ##
================================================
Coverage 76.00% 76.00%
================================================
Files 270 270
Lines 10172 10170 -2
Branches 1155 1154 -1
================================================
- Hits 7731 7730 -1
+ Misses 2122 2120 -2
- Partials 319 320 +1
Continue to review full report at Codecov.
|
AnanyaJha
approved these changes
Oct 27, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes an issue where diagnostics would not clear after successfully executing anonymous apex.
What issues does this PR fix or reference?
#2608, @W-8272124@