feat(perf): org browser retrieve perf enhancements #2756
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #2756 +/- ##
===========================================
+ Coverage 76.02% 76.25% +0.23%
===========================================
Files 271 271
Lines 10235 10273 +38
Branches 1166 1176 +10
===========================================
+ Hits 7781 7834 +53
+ Misses 2128 2105 -23
- Partials 326 334 +8
Continue to review full report at Codecov.
|
| @@ -132,16 +140,92 @@ export class ForceSourceRetrieveExecutor extends SfdxCommandletExecutor< | |||
| } | |||
| } | |||
| } | |||
| export class LibraryRetrieveSourcePathExecutor extends LibraryCommandletExecutor< | |||
There was a problem hiding this comment.
Do we have a test to cover this new code ?
There was a problem hiding this comment.
@lcampos No, I'll add test cases for it.
There was a problem hiding this comment.
Ok, everything else looks good btw
| await this.openResources(this.findResources(components[0], compSet)); | ||
| } | ||
|
|
||
| return result.success; |
There was a problem hiding this comment.
Do we need to output the result table to the channelService?
|
Looks good aside from the one comment I had about the channel service. I discovered a conversion bug that's part of the library through these changes and filed an issue with it. |
* feat(perf): org browser retrieve perf enhancements * chore: removed unnecessary import * chore: added tests
What does this PR do?
What issues does this PR fix or reference?
@W-8242567@