Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: workspaceContext initialization across apex & replay-debugger packages #2868

Merged
merged 8 commits into from
Jan 19, 2021

Conversation

AnanyaJha
Copy link
Collaborator

@AnanyaJha AnanyaJha commented Jan 16, 2021

What does this PR do?

This PR changes how we are initializing the workspaceContext service in the apex and replay-debugger packages. This fixes an issue where 'Run Test' and 'Debug & Run Test' were not picking up the default org when the project was opened for the first time.

What issues does this PR fix or reference?

#2883, @W-8732172@

@AnanyaJha AnanyaJha requested a review from a team as a code owner January 16, 2021 00:46
@codecov
Copy link

codecov bot commented Jan 16, 2021

Codecov Report

Merging #2868 (9343612) into develop (bd8b055) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2868      +/-   ##
===========================================
- Coverage    75.78%   75.76%   -0.02%     
===========================================
  Files          278      277       -1     
  Lines        10653    10639      -14     
  Branches      1229     1228       -1     
===========================================
- Hits          8073     8061      -12     
+ Misses        2238     2237       -1     
+ Partials       342      341       -1     
Impacted Files Coverage Δ
...e-apex-replay-debugger/src/commands/quickLaunch.ts 83.92% <100.00%> (ø)
...de-apex/src/commands/forceApexTestRunCodeAction.ts 82.60% <100.00%> (ø)
...orcedx-vscode-core/src/context/workspaceContext.ts

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd8b055...9343612. Read the comment docs.

@AnanyaJha AnanyaJha merged commit 7d030be into develop Jan 19, 2021
@AnanyaJha AnanyaJha deleted the aj/scratchFix branch January 19, 2021 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants