Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove use of missing telemetry method #2913

Merged
merged 3 commits into from
Feb 2, 2021

Conversation

lcampos
Copy link
Contributor

@lcampos lcampos commented Feb 2, 2021

What does this PR do?

Follow up to PRs #2878 & #2894. This fixes an issue on salesforcedx-vscode-apex, salesforcedx-vscode-apex-replay-debugger and salesforcedx-vscode-visualforce where it fails to find a now removed showTelemetryMessage method.

What issues does this PR fix or reference?

@W-8792554@

@lcampos lcampos requested a review from a team as a code owner February 2, 2021 03:50
@codecov
Copy link

codecov bot commented Feb 2, 2021

Codecov Report

Merging #2913 (2d5a741) into develop (370b787) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #2913   +/-   ##
========================================
  Coverage    75.73%   75.74%           
========================================
  Files          277      277           
  Lines        10638    10637    -1     
  Branches      1230     1230           
========================================
  Hits          8057     8057           
+ Misses        2239     2238    -1     
  Partials       342      342           
Impacted Files Coverage Δ
...s/salesforcedx-vscode-visualforce/src/extension.ts 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 370b787...2d5a741. Read the comment docs.

@lcampos lcampos merged commit 809dbb8 into develop Feb 2, 2021
@lcampos lcampos deleted the lcampos/fix-missing-telemetry branch February 2, 2021 16:51
@lcampos lcampos changed the title fix: missing telemetry method fix: remove use of missing telemetry method Feb 2, 2021
lcampos added a commit that referenced this pull request Feb 2, 2021
lcampos added a commit that referenced this pull request Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants