Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add ability to jump to channel output via the 'Show' button #3081

Merged
merged 3 commits into from
Mar 22, 2021

Conversation

sfsholden
Copy link
Contributor

@sfsholden sfsholden commented Mar 22, 2021

What does this PR do?

Adds back in functionality for jumping to the correct output channel when clicking the 'Show' button.

What issues does this PR fix or reference?

#2987, @W-8935765@

Functionality Before

Clicking the 'Show' button did not redirect the user to the appropriate output channel.
OutputChannelShowBtn_Before

Functionality After

Clicking the 'Show' button redirects the user to the correct output channel.
OutputChannelShowBtn_After

Other Notes

  • This fix also applies for the Apex Plugin & Library.
  • Jumping to the correct output channel upon successful completion for SDR has already been fixed by fix: pop up output channel upon completion of Apex commands #3027.
  • The text "Null Extension Description" is specific only to the dev environment. This does not impact customers.

@codecov
Copy link

codecov bot commented Mar 22, 2021

Codecov Report

Merging #3081 (b40dc52) into develop (8064632) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #3081   +/-   ##
========================================
  Coverage    76.18%   76.18%           
========================================
  Files          276      276           
  Lines        10502    10502           
  Branches      1234     1234           
========================================
  Hits          8001     8001           
  Misses        2157     2157           
  Partials       344      344           
Impacted Files Coverage Δ
...x-vscode-core/src/commands/forceRefreshSObjects.ts 84.04% <ø> (ø)
...scode-lwc/src/commands/forceLightningLwcPreview.ts 89.38% <ø> (ø)
...x-vscode-lwc/src/commands/forceLightningLwcStop.ts 83.33% <ø> (ø)
...-vscode-lwc/src/commands/forceLightningLwcStart.ts 80.80% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8064632...b40dc52. Read the comment docs.

@sfsholden sfsholden marked this pull request as ready for review March 22, 2021 20:35
@sfsholden sfsholden requested a review from a team as a code owner March 22, 2021 20:35
@sfsholden sfsholden merged commit 502575e into develop Mar 22, 2021
@sfsholden sfsholden deleted the sh/sdrFixOutputPannel branch March 22, 2021 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants