Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GitHub feedback] Update Org Picker location #3099

Merged
merged 3 commits into from
Apr 2, 2021

Conversation

ekapner
Copy link
Contributor

@ekapner ekapner commented Mar 29, 2021

What does this PR do?

What issues does this PR fix or reference?

#3095

Functionality Before

We said Org Picker was located on Side Bar

Functionality After

Update docs to say Org Picker is on status bar

@ekapner ekapner requested a review from a team as a code owner March 29, 2021 22:58
@codecov
Copy link

codecov bot commented Mar 29, 2021

Codecov Report

Merging #3099 (9088ec6) into develop (8bcc10c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #3099   +/-   ##
========================================
  Coverage    76.21%   76.21%           
========================================
  Files          276      276           
  Lines        10513    10513           
  Branches      1235     1235           
========================================
  Hits          8012     8012           
  Misses        2157     2157           
  Partials       344      344           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8bcc10c...9088ec6. Read the comment docs.

@@ -118,7 +118,7 @@ You can delete source from your project and from your non-source-tracked org.
To develop in non-scratch orgs and use Org Browser to retrieve source:

1. Open the VS Code editor and from the Command Palette, run **SFDX: Create Project**.
1. In the Side Bar of the code editor, click Org Picker. This opens the Command Palette and you can select a command to authorize an org, Dev Hub, or create a scratch org; Or you can select from the list of authorized orgs.
1. In the code editor's status bar, click Org Picker. This opens the Command Palette and you can select a command to authorize an org, Dev Hub, or create a scratch org; Or you can select from the list of authorized orgs.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two tiny nits:

  • To get around the "This" not having a noun after it, you can reword the second sentence like this: "The Command Palette opens and you can select a command..." (I'm personally not bothered by it, but Acrolinx complains).
  • I think the semi-colon after "..or create a scratch org;" should be a period rather than semi-colon.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I noticed those things but didn't address them. Will do.

@ekapner ekapner merged commit bb3add6 into develop Apr 2, 2021
@ekapner ekapner deleted the ekapner-org-picker-location branch April 2, 2021 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants