-
Notifications
You must be signed in to change notification settings - Fork 393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Apex feature flag & delete CLI code path #3148
Conversation
d1c1f18
to
544511d
Compare
Codecov Report
@@ Coverage Diff @@
## develop #3148 +/- ##
===========================================
+ Coverage 76.01% 76.03% +0.01%
===========================================
Files 276 276
Lines 10548 10409 -139
Branches 1241 1219 -22
===========================================
- Hits 8018 7914 -104
+ Misses 2183 2156 -27
+ Partials 347 339 -8
Continue to review full report at Codecov.
|
packages/salesforcedx-vscode-apex/test/vscode-integration/settings.test.ts
Outdated
Show resolved
Hide resolved
@smaddox-sf I think we'll need to remove the information about the setting on the doc site, but not sure about what other parts of the page should be updated now that this is the only way of running apex commands. |
544511d
to
b5ffca7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AnanyaJha the code looks good and the only remaining update needed is to the Japanese doc article for perf enhancements since it's currently written in English.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor editorial tweaks. I hope I made my changes in both en and ja versions.
Co-authored-by: Emily Kapner <ekapner@salesforce.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for implementing the edits
What does this PR do?
This PR removes the Apex setting and the CLI code path for the following functionality:
SFDX: Get Apex Debug Logs
SFDX: Execute Anonymous Apex with Currently Selected Text/with Editor Contents
SFDX: Run Apex Tests
, Run Tests Code Lens & Run Tests from Sidebarapologies in advance, the PR touches lots of files 馃槄
What issues does this PR fix or reference?
@W-8911035@