Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Apex feature flag & delete CLI code path #3148

Merged
merged 5 commits into from
Apr 19, 2021
Merged

Conversation

AnanyaJha
Copy link
Collaborator

@AnanyaJha AnanyaJha commented Apr 13, 2021

What does this PR do?

This PR removes the Apex setting and the CLI code path for the following functionality:

  • SFDX: Get Apex Debug Logs
  • SFDX: Execute Anonymous Apex with Currently Selected Text/with Editor Contents
  • SFDX: Run Apex Tests, Run Tests Code Lens & Run Tests from Sidebar

apologies in advance, the PR touches lots of files 馃槄

What issues does this PR fix or reference?

@W-8911035@

@codecov
Copy link

codecov bot commented Apr 13, 2021

Codecov Report

Merging #3148 (16702da) into develop (dee99aa) will increase coverage by 0.01%.
The diff coverage is 75.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3148      +/-   ##
===========================================
+ Coverage    76.01%   76.03%   +0.01%     
===========================================
  Files          276      276              
  Lines        10548    10409     -139     
  Branches      1241     1219      -22     
===========================================
- Hits          8018     7914     -104     
+ Misses        2183     2156      -27     
+ Partials       347      339       -8     
Impacted Files Coverage 螖
...rcedx-vscode-apex/src/commands/forceApexExecute.ts 85.93% <酶> (+7.04%) 猬嗭笍
...rcedx-vscode-apex/src/commands/forceApexTestRun.ts 85.71% <酶> (-2.29%) 猬囷笍
...de-apex/src/commands/forceApexTestRunCodeAction.ts 72.16% <0.00%> (-10.57%) 猬囷笍
packages/salesforcedx-vscode-apex/src/settings.ts 100.00% <酶> (酶)
...s/salesforcedx-vscode-apex/src/views/testRunner.ts 69.11% <酶> (-0.89%) 猬囷笍
...rcedx-vscode-core/src/settings/sfdxCoreSettings.ts 45.00% <酶> (+2.14%) 猬嗭笍
...orcedx-vscode-apex/src/commands/forceApexLogGet.ts 54.76% <100.00%> (+10.05%) 猬嗭笍
...rcedx-vscode-apex/src/views/testOutlineProvider.ts 62.50% <100.00%> (-3.44%) 猬囷笍
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update dee99aa...16702da. Read the comment docs.

@brpowell
Copy link
Contributor

@smaddox-sf I think we'll need to remove the information about the setting on the doc site, but not sure about what other parts of the page should be updated now that this is the only way of running apex commands.

Copy link
Contributor

@lcampos lcampos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AnanyaJha the code looks good and the only remaining update needed is to the Japanese doc article for perf enhancements since it's currently written in English.

Copy link
Contributor

@ekapner ekapner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor editorial tweaks. I hope I made my changes in both en and ja versions.

Co-authored-by: Emily Kapner <ekapner@salesforce.com>
Copy link
Contributor

@ekapner ekapner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for implementing the edits

@AnanyaJha AnanyaJha merged commit 01ff453 into develop Apr 19, 2021
@AnanyaJha AnanyaJha deleted the aj/removeApex branch April 19, 2021 19:15
lukecotter pushed a commit to lukecotter/salesforcedx-vscode that referenced this pull request May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants