feat: use SDR for conflict detect perf improvements #3246
Conversation
| this.sourceComponents = this.isManifest | ||
| ? await ComponentSet.fromManifest({ | ||
| manifestPath: this.componentPath, | ||
| resolveSourcePaths: [this.projectPath] |
There was a problem hiding this comment.
I think we need to make this a list of the project's package directories. If projectPath is the root of the project, it'll still work but will end up over-scanning irrelevant files like node_modules which could impact the performance
| getRootWorkspacePath(), | ||
| this.isManifest | ||
| ); | ||
| return await this.cacheService.getSourceComponents(); |
There was a problem hiding this comment.
Nit, remove await since we're already returning a promise
| if (throwErrorOnFailure) { | ||
| throw error; | ||
| } | ||
| private async handleCacheResults( |
There was a problem hiding this comment.
Where is this handleCacheResults used and how is this different from the one in forceSourceDiff.ts ?
There was a problem hiding this comment.
Never mind, so this is specifically used for the conflict detection part here. I think we need a separate diffService.ts and move some of the diff specific code there. Can be part of a separate devchoice/refactoring story.
There was a problem hiding this comment.
Agreed. There is some overlap, but they will diverge as conflict detection progresses.
What does this PR do?
What issues does this PR fix or reference?
@W-9164033@