feat: introduce 3 Apex Test Suite commands #3435
Conversation
|
Wow, awesome to see this added to the product! 🎉🎉 |
| return { | ||
| label: testSuite.TestSuiteName, | ||
| // @ts-ignore | ||
| description: testSuite.Id, |
There was a problem hiding this comment.
The field is named incorrectly in the apex-node package so we'll need to update that so we can remove the ts-ignore here
| @@ -17,5 +17,8 @@ | |||
| "force_apex_test_last_method_run_text": "SFDX: Re-Run Last Run Apex Test Method", | |||
| "force_apex_test_class_run_text": "SFDX: Run Apex Test Class", | |||
| "force_apex_test_method_run_text": "SFDX: Run Apex Test Method", | |||
| "force_apex_test_run_text": "SFDX: Run Apex Tests" | |||
| "force_apex_test_run_text": "SFDX: Run Apex Tests", | |||
| "force_apex_test_suite_run_text": "SFDX: Run Apex Test Suite", | |||
There was a problem hiding this comment.
please have @sbudhirajadoc review this
There was a problem hiding this comment.
the messages were approved beforehand in a separate doc! thanks sonal!
| const apexClassItems: ApexTestQuickPickItem[] = []; | ||
|
|
||
| apexClasses.forEach(apexClass => { | ||
| const fileContent = readFileSync(apexClass.fsPath).toString(); |
There was a problem hiding this comment.
We should keep in mind the perf impact of this. I tested in perf-project and it took ~1s for loading the menu.
There was a problem hiding this comment.
A change at this moment might not be needed, but if there's performance issues we should consider if we can reuse information from language server.
There was a problem hiding this comment.
I agree - I followed the pattern we're using elsewhere, but I think both should be examined to see if we can find a better approach.
What does this PR do?
This PR introduces Test Suites to our command palette. It adds the following commands:
SFDX: Run Apex Test SuiteSFDX: Create Apex Test SuiteSFDX: Add Tests to Apex Test SuiteWhat issues does this PR fix or reference?
@W-9632080@
@W-9632072@
@W-9632048@
Functionality Before
new functionality!
Functionality After
Screen.Recording.2021-06-04.at.10.23.30.AM.mov