fix: fix trace flag update error #3550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
there was an error with the trace flag start and end date overlapping, which is fixed by setting the start date on the trace flag when it is created and updated.
rcoringrato-sfdc
approved these changes
Sep 20, 2021
jag-j
pushed a commit
that referenced
this pull request
Sep 29, 2021
There was an error with the trace flag start and end date overlapping, which is fixed by setting the start date on the trace flag when it is created and updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
There was an error with the trace flag start and end date overlapping, which is fixed by setting the start date on the trace flag when it is created and updated. This issue was reported online, and also discovered while testing the tail log command.
What issues does this PR fix or reference?
#@W-9924469@
Functionality Before
When a trace flag is updated with the replay debugger, we receive an error message:
This entity is already being traced by a trace flag with a start and expiration date that overlap this trace flag's start and expiration date.: Traced Entity ID. To get around this error, users have to delete the trace flag and create a new one.Functionality After
Trace flags can be updated from the replay debugger directly.