feat: custom templates for vscode #3563
Conversation
.../salesforcedx-vscode-core/test/vscode-integration/commands/templates/customTemplates.test.ts
Outdated
Show resolved
Hide resolved
| @@ -18,7 +18,7 @@ import { forceApexClassCreate } from '../../../../src/commands/templates/forceAp | |||
| import { nls } from '../../../../src/messages'; | |||
| import { notificationService } from '../../../../src/notifications'; | |||
| import { telemetryService } from '../../../../src/telemetry'; | |||
| import { getRootWorkspacePath } from '../../../../src/util'; | |||
| import { ConfigUtil, getRootWorkspacePath } from '../../../../src/util'; | |||
There was a problem hiding this comment.
Good catch on this one! Did this come up with any of the other create commands?
There was a problem hiding this comment.
No, telemetry test is only for apex class create since the other template types are very similar. It might be belonging to its own test file though, but not a pressing need to refactor now.
There was a problem hiding this comment.
Works great! Ran lots of tests to check error states and happy paths with local and remote repos. I love that the code is smart enough to store multiple templates locally, and switch between cached versions as the desired URL changes.
My only feedback during testing is that it's not quite clear which cached directory you need to delete if you want to re-download the remote repository. That may be a good motivating factor for eventually offering an option through VS Code to update the cached templates, but for now users will just need to navigate into the directories to remember which is which.
Great work! 🎉
| "@salesforce/salesforcedx-utils-vscode": "52.16.0", | ||
| "@salesforce/source-deploy-retrieve": "4.1.1", | ||
| "@salesforce/source-deploy-retrieve": "4.4.7", |
There was a problem hiding this comment.
Awesome. I had a PR in flight for this. I'll take that off.
What does this PR do?
Support custom templates in VS Code
What issues does this PR fix or reference?
@W-9790311@