Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update lsp - namespace autocomplete fix,telemetry,soql lib deletion @W-8340576@ #3568

Merged
merged 1 commit into from
Oct 8, 2021

Conversation

jag-j
Copy link
Contributor

@jag-j jag-j commented Oct 5, 2021

What does this PR do?

Updates LSP jar. Includes fix to suggest correct autocompletes in projects with namespace, telemetry and deletion of SOQL library.

What issues does this PR fix or reference?

@W-8340576@, #2615

Functionality Before

Namespace included in autocomplete suggestions

Functionality After

Namespace not included in autocomplete suggestions
Total size of the LSP jar is down to 15MB from 19 MB

@jag-j jag-j requested a review from a team as a code owner October 5, 2021 23:02
@jag-j jag-j requested a review from randi274 October 5, 2021 23:02
Copy link
Contributor

@randi274 randi274 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Confirmed the issue before, and that you no longer see the namespace added with the autocomplete methods.

@jag-j jag-j merged commit 631b8cf into develop Oct 8, 2021
@jag-j jag-j deleted the jj/update-apex-lsp-jar branch October 8, 2021 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants