Ra/remove the deploy/retrieve experimental setting #3580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
These changes look good Ritam! And good catch on the japanese translation file as well. For tests, I'd just make sure to delete the ones for each deleted executor as well |
jag-j
reviewed
Oct 13, 2021
packages/salesforcedx-vscode-core/src/commands/forceSourceDeploySourcePath.ts
Show resolved
Hide resolved
|
+1 to what Ananya said. This looks good. I just left a minor comment. |
RitamAgrawal
force-pushed
the
ra/remove_the_deploy/retrieve_experimental_setting
branch
from
2c0a7f6
to
50d590c
Compare
jag-j
reviewed
Oct 19, 2021
packages/salesforcedx-vscode-core/test/vscode-integration/commands/forceSourceDeploy.test.ts
Show resolved
Hide resolved
AnanyaJha
approved these changes
Oct 19, 2021
RitamAgrawal
deleted the
ra/remove_the_deploy/retrieve_experimental_setting
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removes
Salesforcedx-vscode-core> Experimental: Deploy Retrieveoption touse library for deploy and retrieve commands instead of CLIfrom settings.What issues does this PR fix or reference?
#W-9965394
Functionality Before
Functionality After
Doesn't display the option.