Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unnecessary SDR errors #3631

Merged
merged 3 commits into from
Nov 4, 2021
Merged

fix: unnecessary SDR errors #3631

merged 3 commits into from
Nov 4, 2021

Conversation

randi274
Copy link
Contributor

@randi274 randi274 commented Nov 3, 2021

What does this PR do?

removed SDR from base deploy, since scratch orgs were running into errors in SDR for missing paths

What issues does this PR fix or reference?

@W-10004893@

Functionality Before

When pushing code to scratch orgs, error messages were being quietly logged to our telemetry.

Functionality After

Telemetry will be cleaner, and make it easier to see real errors.

removed SDR from base deploy, since scratch orgs were encountering errors in SDR for missing paths
@randi274 randi274 requested a review from jag-j November 3, 2021 18:25
@randi274 randi274 requested a review from a team as a code owner November 3, 2021 18:25
@randi274 randi274 merged commit c2fffcc into develop Nov 4, 2021
@randi274 randi274 deleted the randi/limit-SDR-errors branch November 4, 2021 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants