-
Notifications
You must be signed in to change notification settings - Fork 393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Org Browser + Multi Select Files #3639
Conversation
@jeffb-sfdc this is early because I am in training next week, so please do not approve until feature release. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minor stuff.
- strings: string(length) | ||
- textarea: textarea(length) | ||
- email: email(length) | ||
- Lookup: lookup(reference) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is "Lookup" capitalized?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Lookup" is more of an alias, for when an object has a foreign-key relationship with another object. For example, the Campaign
object has Parent (reference)
and Owner (reference)
, so my suggestion would be to change the docs to lookup: lookup(reference)
. Also, we should probably pluralize each:
- strings: string(length)
- textareas: textarea(length)
- emails: email(length)
- lookups: lookup(reference)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jeffb-sfdc for the explanation!
Co-authored-by: Emily Kapner <ekapner@salesforce.com>
Also https://gus.lightning.force.com/lightning/r/ADM_Work__c/a07EE00000NGcs7YAD/view
and
https://gus.lightning.force.com/lightning/r/ADM_Work__c/a07EE00000IYEpOYAX/view
What does this PR do?
We have updated docs to include information about --
What issues does this PR fix or reference?
Functionality Before
Functionality After
Relevant doc updates were made.