Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Org Browser + Multi Select Files #3639

Merged
merged 6 commits into from
Nov 11, 2021
Merged

Org Browser + Multi Select Files #3639

merged 6 commits into from
Nov 11, 2021

Conversation

sbudhirajadoc
Copy link
Contributor

Also https://gus.lightning.force.com/lightning/r/ADM_Work__c/a07EE00000NGcs7YAD/view
and
https://gus.lightning.force.com/lightning/r/ADM_Work__c/a07EE00000IYEpOYAX/view

What does this PR do?

We have updated docs to include information about --

  1. Multi-selecting files and folders in explorer for Source Deploy/Retrieve
  2. Fields and field details for custom objects.

What issues does this PR fix or reference?

Functionality Before

Functionality After

Relevant doc updates were made.

@sbudhirajadoc sbudhirajadoc requested a review from a team as a code owner November 9, 2021 19:46
@sbudhirajadoc
Copy link
Contributor Author

@jeffb-sfdc this is early because I am in training next week, so please do not approve until feature release. Thanks!

@forcedotcom forcedotcom deleted a comment from sbudhirajadoc Nov 10, 2021
Copy link
Contributor

@ekapner ekapner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor stuff.

docs/_articles/en/user-guide/development-models.md Outdated Show resolved Hide resolved
- strings: string(length)
- textarea: textarea(length)
- email: email(length)
- Lookup: lookup(reference)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is "Lookup" capitalized?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Lookup" is more of an alias, for when an object has a foreign-key relationship with another object. For example, the Campaign object has Parent (reference) and Owner (reference), so my suggestion would be to change the docs to lookup: lookup(reference). Also, we should probably pluralize each:

-  strings: string(length)
-  textareas: textarea(length)
-  emails: email(length)
-  lookups: lookup(reference)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jeffb-sfdc for the explanation!

@sbudhirajadoc sbudhirajadoc merged commit 86c8d87 into develop Nov 11, 2021
@sbudhirajadoc sbudhirajadoc deleted the sonal/236b_updates branch November 11, 2021 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants