Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update i18n.ts #3665

Merged
merged 6 commits into from
Nov 23, 2021
Merged

Update i18n.ts #3665

merged 6 commits into from
Nov 23, 2021

Conversation

sbudhirajadoc
Copy link
Contributor

@sbudhirajadoc sbudhirajadoc commented Nov 22, 2021

updates broken doc links.

What does this PR do?

Fixes broken doc link.

What issues does this PR fix or reference?

#3664
@W-10215396@

Functionality Before

doc links was broken on lines 23,156 and in the functions

Functionality After

doc link fixed.

updated broken doc link.
@sbudhirajadoc sbudhirajadoc requested a review from a team as a code owner November 22, 2021 20:20
@sbudhirajadoc sbudhirajadoc requested review from xyc and a team November 22, 2021 20:20
@sbudhirajadoc sbudhirajadoc requested review from randi274 and removed request for xyc November 22, 2021 20:29
Japanese branch update
Copy link
Contributor

@randi274 randi274 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sbudhirajadoc for getting this fixed so quickly!

@@ -20,7 +20,7 @@ export const messages = {
command_canceled: '%s was canceled.',
force_lightning_lwc_start_text: 'SFDX: Start Local Development Server',
force_lightning_lwc_start_not_found:
'To run this command, install the @salesforce/lwc-dev-server plugin. For more info, see [https://developer.salesforce.com/docs/component-library/documentation/lwc/lwc.get_started_local_dev](https://developer.salesforce.com/docs/component-library/documentation/lwc/lwc.get_started_local_dev).',
'To run this command, install the @salesforce/lwc-dev-server plugin. For more info, see [https://developer.salesforce.com/tools/vscode/en/localdev/set-up-lwc-local-dev](https://developer.salesforce.com/tools/vscode/en/localdev/set-up-lwc-local-dev).',
Copy link
Contributor

@ekapner ekapner Nov 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sure this is my fault - but why don't we NOW go with: For more info, see [Set Up LWC Local Development](url) ??

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. @ekapner Thanks!

Copy link
Contributor

@ekapner ekapner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment about using title instead of URL for link

@sbudhirajadoc sbudhirajadoc requested review from ekapner and removed request for ekapner November 23, 2021 15:45
@sbudhirajadoc sbudhirajadoc merged commit 50dfc58 into develop Nov 23, 2021
@sbudhirajadoc sbudhirajadoc deleted the sonal/url_update_lwc_doc branch November 23, 2021 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update URL for lwc-dev-server documentation
4 participants