Jb/add trace flag auto delete #3812
Conversation
| import { Connection } from '@salesforce/core'; | ||
|
|
||
| /** | ||
| * TraceFlagsRemover is a singleton which deletes trace flags not created by the user. |
There was a problem hiding this comment.
The comment is confusing. Did you mean "deletes trace flags created by the user"?
There was a problem hiding this comment.
In ensureTraceFlags(), the code checks whether an existing trace flag exists (getTraceFlagForUser()). If a trace flag doesn't exist, we create a trace flag ourselves (automatically/programmatically). When we create a trace flag, this class (TraceFlagsRemover) then cleans up and removed the trace flag.
Would, "TraceFlagsRemover is a singleton which deletes trace flags programmatically created when an existing trace flag isn't present" be better?
There was a problem hiding this comment.
Maybe ...which deletes trace flags created by the extensions.?
There was a problem hiding this comment.
sgtm... I'll change it to that.
packages/salesforcedx-utils-vscode/test/unit/helpers/traceFlagsRemover.test.ts
Show resolved
Hide resolved
|
Looking great. I'm good to approve once I can test locally with the .vsix |
What does this PR do?
Implements the auto removal of temporary trace flags.
What issues does this PR fix or reference?
@W-10288383@
Functionality Before
With the new updates to the "SFDX: Launch Apex Replay Debugger with Current File” command, a trace flag was created behind the scenes, but wasn't cleaned up after the debugging session finished.
Functionality After
Now, after finished debugging, if the trace flag was created by the command, it is deleted from the org (existing trace flags are left untouched)