fix: dependabot-library-updates #4388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffb-sfdc
commented
Aug 23, 2022
| @@ -243,14 +243,14 @@ function getDialogStartingPath(): vscode.Uri | undefined { | |||
| const lastOpenedLogFolder = extContext.workspaceState.get<string>( | |||
| LAST_OPENED_LOG_FOLDER_KEY | |||
| ); | |||
| if (lastOpenedLogFolder && pathExists.sync(lastOpenedLogFolder)) { | |||
| if (lastOpenedLogFolder && pathExists.pathExistsSync(lastOpenedLogFolder)) { | |||
There was a problem hiding this comment.
With the update of the newer pathExist library, sync() was replaced with pathExistSync()
jeffb-sfdc
commented
Aug 23, 2022
| @@ -13,7 +13,11 @@ import { createSandbox, SinonSandbox, SinonStub } from 'sinon'; | |||
| import * as vscode from 'vscode'; | |||
| import { SET_JAVA_DOC_LINK } from '../../src/constants'; | |||
| import { nls } from '../../src/messages'; | |||
| import { checkJavaVersion, JAVA_HOME_KEY, resolveRequirements } from '../../src/requirements'; | |||
| import { | |||
There was a problem hiding this comment.
Auto-formatting that took placed when I saved the file.
jeffb-sfdc
commented
Aug 23, 2022
| @@ -69,7 +73,9 @@ describe('Java Requirements Test', () => { | |||
| const result = await checkJavaVersion('~/java_home'); | |||
| expect(result).to.equal(true); | |||
| } catch (err) { | |||
| fail(`Should not have thrown when the Java version is 17. The error was: ${err}`); | |||
| fail( | |||
There was a problem hiding this comment.
more auto-formatting
This was referenced Aug 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR updates the following libraries:
commitlint/cli
commitlint/config-conventional
glob
path-exists
types/path-exists
...and makes the following PRs redundant:
#4174
#4249
#4390