Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Relative StateFolder Path from projectPaths for MetadataCacheService #4516

Merged
merged 4 commits into from
Oct 27, 2022

Conversation

klewis-sfdc
Copy link
Contributor

What does this PR do?

Imports the relative path to the state folder from the utils package, which imports the sfdx-core library, over referencing the '.sfdx' directory directly.

What issues does this PR fix or reference?

@W-11633503@

Functionality Before

'.sfdx' directory is referenced directly.

Functionality After

State folder is referenced using imported folder path from utils package.

@klewis-sfdc klewis-sfdc requested a review from a team as a code owner October 26, 2022 14:58
Copy link
Contributor

@CristiCanizales CristiCanizales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to go to me :) Thank you!

Copy link
Contributor

@gbockus-sf gbockus-sf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳 🚢 LGTM

@klewis-sfdc klewis-sfdc merged commit d28fe28 into develop Oct 27, 2022
@klewis-sfdc klewis-sfdc deleted the ken/replace-metadata-cache-svc-use-of-sfdx branch October 27, 2022 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants