Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing Experience Cloud targets #4578

Merged
merged 5 commits into from
Dec 8, 2022
Merged

fix: add missing Experience Cloud targets #4578

merged 5 commits into from
Dec 8, 2022

Conversation

CristiCanizales
Copy link
Contributor

@CristiCanizales CristiCanizales commented Dec 8, 2022

What does this PR do?

This PR adds missing Experience Cloud targets to the js-meta XML validation.

What issues does this PR fix or reference?

@W-12188466@

Functionality Before

The js-meta validation is missing two Experience Cloud targets for LWR sites.

Functionality After

The js-meta validation no longer declares the valid targets as invalid.

@CristiCanizales CristiCanizales added the type:community-contrib Community Contribution Pull Requests label Dec 8, 2022
@git2gus
Copy link

git2gus bot commented Dec 8, 2022

This issue has been linked to a new work item: W-12188466

@CristiCanizales CristiCanizales self-assigned this Dec 8, 2022
@CristiCanizales CristiCanizales merged commit 4174075 into develop Dec 8, 2022
@CristiCanizales CristiCanizales deleted the pr/3371 branch December 8, 2022 23:39
@CristiCanizales
Copy link
Contributor Author

Thanks for contributing @muenzpraeger !😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:community-contrib Community Contribution Pull Requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants