Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update Core's Config Aggregator After Writing to Config File #4661

Merged
merged 8 commits into from
Feb 13, 2023

Conversation

klewis-sfdc
Copy link
Contributor

What does this PR do?

The extensions have seen some cacheing issues when using the types from the @salesforce/core library.

This seems to be due to the differences in how the cli and VS Code use node processes.

The cli is often running in one-off processes, while VS Code uses long-running processes.

Because of this difference, we are seeing that some manual steps need to be taken to ensure that the core types are updated with the latest info after updating stored data (like configuration values) in VS Code.

What issues does this PR fix or reference?

  • Forces the ConfigAggregator to read the Config file after it is updated with new information.

@W-9466545@

Functionality Before

  • The ConfigAggregator would not always be up-to-date in subsequent calls after calling configUtil.setUsernameOrAlias

Functionality After

  • The ConfigAggregator is always up-to-date in subsequent calls after calling configUtil.setUsernameOrAlias

@klewis-sfdc klewis-sfdc requested a review from a team as a code owner February 3, 2023 14:47
@klewis-sfdc klewis-sfdc requested review from jeffb-sfdc, gbockus-sf and RitamAgrawal and removed request for jeffb-sfdc February 3, 2023 14:47
Copy link
Member

@RitamAgrawal RitamAgrawal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QE:
Testing: SFDX: Deploy Source to org with Detect Conflict At Sync setting on.
❌ Throws an error when testing with VSIX
✅ runs successfully when testing on local development environment.

#4675)

* chore: update request-light to avoid got issue

* chore: type updates due to request-light bump
Copy link
Member

@RitamAgrawal RitamAgrawal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QE (approved):
✅ SFDX: Create an Apex Class
✅ SFDX: Deploy Source to Org with Detect Conflict At Sync setting on.
✅ SFDX: Create a scratch Org
✅ SFDX: Push Source to Org

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants