Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add ExperiencePropertyType to metadata dictionary #4761

Closed
wants to merge 5 commits into from

Conversation

Kaaviyan
Copy link
Contributor

What does this PR do?

This PR adds ExperiencePropertyType to the metadata dictionary. Similar to the wave template, the ExperiencePropertyType metadata type doesn't have a -meta.xml instead it has a static schema.json file for each metadata. Adding an entry to the metadata dictionary to fix this issue

What issues does this PR fix or reference?

@W-12766917@

Functionality Before

Retrieving ExperiencePropertyType throws an error and doesn't show the overwrite popup when metadata locally exists

Functionality After

Retrieving ExperiencePropertyType shows overwrite popup warning if it exists locally and no error is thrown when retrieving this type

@Kaaviyan Kaaviyan requested a review from a team as a code owner March 30, 2023 08:25
Copy link
Contributor

@CristiCanizales CristiCanizales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! Looks good. Could you please add a jest test that covers your changes? 🙂

@Kaaviyan
Copy link
Contributor Author

Kaaviyan commented Apr 4, 2023

Thank you for taking a look @CristiCanizales
I've added some tests. Please let me know if it works :)

@CristiCanizales CristiCanizales added the type:community-contrib Community Contribution Pull Requests label Apr 5, 2023
@git2gus
Copy link

git2gus bot commented Apr 5, 2023

This issue has been linked to a new work item: W-12980533

@CristiCanizales CristiCanizales mentioned this pull request Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:signed type:community-contrib Community Contribution Pull Requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants