fix: remove legacy source tracking commands #4771
Conversation
There was a problem hiding this comment.
Looking real good @CristiCanizales! Builds are passing, and a quick spot check of the push/pull commands is working too.
I noticed only one extra place for cleanup. I saw CommandVersion is exported from sfdxCommandlet (and was originally added for the purpose of adding the legacy commands!) but is no longer being used. Can you remove that enum and subsequent references over there?
packages/salesforcedx-vscode-core/src/commands/forceSourcePull.ts
Outdated
Show resolved
Hide resolved
packages/salesforcedx-vscode-core/src/commands/forceSourcePush.ts
Outdated
Show resolved
Hide resolved
|
Sure! Nice catch. Thanks! |
CristiCanizales
force-pushed
the
cristi/remove-legacy-commands
branch
from
8eee3c7
to
3a4113f
Compare
There was a problem hiding this comment.
Testing:
✅ Legacy commands are no longer visible, and 'legacy' is gone from the code base
✅ Force source pull generates expected command
✅ Force source push generates expected command
✅ Create conflicts -> overwrite w/ push - generates expected command
✅ Create conflicts -> overwrite w/ pull - generates expected command
✅ Deploy on save for push -> does push, and generates expected command
✅ Deploy on save for override conflicts on push -> does push and generates expected command
❓ I am seeing some strange behavior around conflict detection, but I don't believe it's a result of the changes in this PR. Will follow up with Ken and see what he makes of it (as some of this may be fixed in his subsequent WIs)
What does this PR do?
Removes the legacy versions of the Pull, Push and View Changes commands. Pretty much reverts most of the changes introduced with #3839
What issues does this PR fix or reference?
@W-12947655@
Functionality Before
The following commands were visible/usable:
Functionality After
The following commands are not visible/usable: