feat: in container mode, disable LWC preview with error #4983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
show error if container mode - WIP BREAKING CHANGE: WIP
ryannmcq
force-pushed
the
rs/container-lwc-preview
branch
from
04ce2ba
to
2e9aad1
Compare
There was a problem hiding this comment.
@ryannmcq Looks Good! Have posted a clarifying question and waiting for doc review on error message.
packages/salesforcedx-vscode-lwc/src/commands/forceLightningLwcPreview.ts
Show resolved
Hide resolved
packages/salesforcedx-vscode-lwc/test/jest/commands/forceLightningLwcPreview.test.ts
Show resolved
Hide resolved
RitamAgrawal
approved these changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Disables the LWC preview command when the extension is running in a container (e.g. Code Builder) by displaying an error toast that explains why the command is unavailable.
Note: there's a directive from product not to hide the command entirely in this situation because it results in support calls from customers that a command is missing.
What issues does this PR fix or reference?
@W-13579717@
Functionality Before
In a container, LWC preview command results in an error with instructions that won't work in a container:
Screen.Recording.2023-07-17.at.4.16.22.PM.mov
Functionality After
In a container, LWC preview command results in an error message explaining the command is unavailable in a container:
Screen.Recording.2023-07-17.at.4.25.34.PM.mov