Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ra/upgrade core v3 to v4 #5001

Merged
merged 40 commits into from
Aug 4, 2023
Merged

Ra/upgrade core v3 to v4 #5001

merged 40 commits into from
Aug 4, 2023

Conversation

RitamAgrawal
Copy link
Member

@RitamAgrawal RitamAgrawal commented Aug 1, 2023 •
edited

What does this PR do?

  • Bumps @salesforce/core to ^4.0.1
  • Bumps @salesforce/ source-deploy-retrieve to ^9.1.0
  • Bumps @salesforce/sorce-tracking to 4.1.3
  • Bumps @salesforce-templates to 58.0.1
  • Bumps jsforce to 2.0.0-beta.27
  • Migrated from using testSetup() --> TestContext()

What issues does this PR fix or reference?

@W-13577566@

Functionality Before

Extensions were using salesforce/core version 3

Functionality After

Extensions are using salesforce/core version 4

@RitamAgrawal
feat: update testSetup to TestContext
f6d093a
@RitamAgrawal
feat: update dependencies
bbc832b
@RitamAgrawal
feat: define testContext within describe
07cc917
@RitamAgrawal
fix: lint
905fc8d
@RitamAgrawal
chore: add description MockExtensionContext
17a555c
@RitamAgrawal
chore: add type of property description
31aa37f
@RitamAgrawal
Merge branch 'develop' into ra/upgrade_core_v4
f9ea118
@RitamAgrawal
chore: remove duplicate declarations
4ace919
@RitamAgrawal
chore: update package-lock
d184115
@RitamAgrawal
chore: temp eliminating files failing on remote
dcd07ea
@RitamAgrawal
chore: running remaining tests
61cad07
@RitamAgrawal
chore: lint error
1592a1e
@RitamAgrawal
chore: use inbuilt sb
ba262cd
@RitamAgrawal
chore: lint
3fefe70
@RitamAgrawal
chore: lint
d210d24
@RitamAgrawal
chore: remove afterEach
837354c
@RitamAgrawal
Merge branch 'develop' into ra/upgrade_core_v4
809fd3a
@RitamAgrawal
chore: revert experimental changes
baa97b6
@RitamAgrawal
chore: use built-in sandbox
4a8b26c
@RitamAgrawal
chore: add logs to debug
ce278f2
@RitamAgrawal
chore: upgrade salesforce-templates
29144ed
@RitamAgrawal
chore: update package lock
8310684
@RitamAgrawal
chore: pin core version for utils-vscode package
3fc570b
@RitamAgrawal
chore: update jsforce
6a1c5c7
@RitamAgrawal
chore: update package lock
32b99a0
@RitamAgrawal
chore: update deps and testSetup class
d65d135
@RitamAgrawal
chore: add idEnabled prop to mock data
8a8a593
@RitamAgrawal
chore: update package-lock
3b77d9d
@RitamAgrawal RitamAgrawal marked this pull request as ready for review August 2, 2023 20:29
@RitamAgrawal RitamAgrawal requested a review from a team as a code owner August 2, 2023 20:29
gbockus-sf
gbockus-sf reviewed Aug 3, 2023
View reviewed changes
Copy link
Contributor

@gbockus-sf gbockus-sf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Only thing I suggest is making sure we have a WI in the backlog to ensure we get back to getting the number packaged version of core/templates back to 1 (reducing the size of the vsix files)

@RitamAgrawal
Copy link
Member Author

This upgrade has increased our vsixes by 6.5MB I will create a WI to keep track of versions of salesforce/templates and heroku/core-functions dependencies.

CristiCanizales
CristiCanizales approved these changes Aug 4, 2023
View reviewed changes
Copy link
Contributor

@CristiCanizales CristiCanizales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since build and tests are passing, ✅

Nice work on this Ritam!! 🏆

@RitamAgrawal RitamAgrawal merged commit 0cb5339 into develop Aug 4, 2023
16 checks passed
@RitamAgrawal RitamAgrawal deleted the ra/upgrade_core_v3_to_v4 branch August 4, 2023 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gbockus-sf gbockus-sf gbockus-sf left review comments

@CristiCanizales CristiCanizales CristiCanizales approved these changes

@smarvez smarvez Awaiting requested review from smarvez smarvez is a code owner automatically assigned from forcedotcom/ide-experience

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@RitamAgrawal @gbockus-sf @CristiCanizales