Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change location of target-dev-hub constant declaration to salesforcedx-utils-vscode folder #5011

Merged
merged 2 commits into from
Aug 2, 2023

Conversation

daphne-sfdc
Copy link
Contributor

What does this PR do?

While changing from SFDX style to SF style variables, the constants were placed in orgConfigProperties.d.ts, which is located inside node_modules. This change places "target-dev-hub" in salesforcedx-utils-vscode/src/constants.ts instead.

What issues does this PR fix or reference?

[@W-13774979@] (https://gus.lightning.force.com/lightning/r/ADM_Work__c/a07EE00001WMXibYAH/view)

Functionality Before/After

This is a change in the location of a variable that does not have any impact on the functionality of the code.

@daphne-sfdc daphne-sfdc requested a review from a team as a code owner August 1, 2023 21:34
Copy link
Contributor

@CristiCanizales CristiCanizales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!
I tested auth/default org related features and all good ✅

@daphne-sfdc daphne-sfdc merged commit 0628bf9 into develop Aug 2, 2023
16 checks passed
@daphne-sfdc daphne-sfdc deleted the daphne/update-targetdevhub-location branch August 2, 2023 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants