Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove support for java 8 #5078

Merged
merged 6 commits into from
Sep 19, 2023
Merged

fix: remove support for java 8 #5078

merged 6 commits into from
Sep 19, 2023

Conversation

peternhale
Copy link
Contributor

@W-14067954@

remove support for java 8
update messages and extension config

@peternhale
fix: remove support for java 8
b609096 
@W-14067954@

remove support for java 8
update messages and extension config
@peternhale peternhale requested a review from a team as a code owner September 7, 2023 21:23
RitamAgrawal and others added 2 commits September 8, 2023 05:25
@RitamAgrawal @peternhale
chore: fix build (#5080)
76b4e3d
@sbudhirajadoc @AnanyaJha
@marmorgan1313 @peternhale
docs: einstein for developers (#5053)
6f5ac19 
* docs: einstien for developers

first commit

* docs: japanese files and sidebar

commit 2

* docs: fix sidebar

fixed filename

* Update sidebar.yml

* docs: some more doc updates

new side bar screenshots and text

* Update einstein-apex.md

* docs: apex update

* Update einstein-apex.md

* docs: sample code topic

fixed formatting

* Update einstein-example-prompts.md

commiting again because changes disappeared.

* Update einstein-setup.md

redoing missing commit.

* Update einstein-setup.md

* Update einstein-setup.md

* docs: new sidebar image

* Update einstein-setup.md

* Update einstein-setup.md

* Update einstein-setup.md

* Update einstein-setup.md

updated image

* docs: new image

* docs: update side bar images

* docs: bunch of updates

edits and such

* Update einstein-setup.md

* docs: pm feedback

* docs: setup page update

* Update einstein-setup.md

giving up on buttons.

* Update einstein-overview.md

added subsection

* Update einstein-setup.md

removed (beta)

* Update einstein-telemetry.md

* Update einstein-example-prompts.md

* Update einstein-overview.md

from acrolinx

* Update einstein-setup.md

acrolinx suggests

* Update einstein-overview.md

* Update java-setup.md

Java 8 update -- removed mention

* Update install.md

removed mention of Java 8 and added "17 or later".

* Update einstein-setup.md

* docs: setup and codegen desc update

* docs: beta terms of use and code builder setup

* Update einstein-setup.md

* Update einstein-setup.md

extension marketplace link

* Update einstein-setup.md

* Update recommended-extensions.md

Added a new link for Salesforce Code Analyzer.

* Update recommended-extensions.md

* Update einstein-setup.md

numbering won't take.

* Update einstein-setup.md

added more steps to the scratch org creation section.

* Update einstein-setup.md

* Update einstein-setup.md

* Update docs/_articles/en/einstein/einstein-apex.md

Co-authored-by: AnanyaJha <a.jha@salesforce.com>

* docs: einstein in a scratch org update

* docs: prompt examples

* docs: trailblazer group

added information about trailblazer group.

* Update einstein-setup.md

* Update einstein-setup.md

enhanced domains enablement

* Update einstein-setup.md

got rid of funky numbering issues.

* Update einstein-telemetry.md

* Update einstein-feedback.md

removed references to pilot

* Update einstein-troubleshoot.md

* Update einstein-glossary.md

* Update docs/_articles/en/einstein/einstein-overview.md

Co-authored-by: Martha Morgan <mmorgan@salesforce.com>

* Update docs/_articles/en/vscode-desktop/recommended-extensions.md

Co-authored-by: Martha Morgan <mmorgan@salesforce.com>

* Update sidebar.yml

* Update docs/_articles/en/einstein/einstein-apex.md

Co-authored-by: Martha Morgan <mmorgan@salesforce.com>

* Update docs/_articles/en/einstein/einstein-apex.md

Co-authored-by: Martha Morgan <mmorgan@salesforce.com>

* Update docs/_articles/en/einstein/einstein-apex.md

Co-authored-by: Martha Morgan <mmorgan@salesforce.com>

* Update docs/_articles/en/einstein/einstein-apex.md

Co-authored-by: Martha Morgan <mmorgan@salesforce.com>

* Update docs/_articles/en/einstein/einstein-apex.md

Co-authored-by: Martha Morgan <mmorgan@salesforce.com>

* Update docs/_articles/en/einstein/einstein-apex.md

Co-authored-by: Martha Morgan <mmorgan@salesforce.com>

* Update docs/_articles/en/einstein/einstein-apex.md

Co-authored-by: Martha Morgan <mmorgan@salesforce.com>

* Update docs/_articles/en/einstein/einstein-apex.md

Co-authored-by: Martha Morgan <mmorgan@salesforce.com>

* Update docs/_articles/en/einstein/einstein-apex.md

Co-authored-by: Martha Morgan <mmorgan@salesforce.com>

* Update docs/_articles/en/einstein/einstein-example-prompts.md

Co-authored-by: Martha Morgan <mmorgan@salesforce.com>

* Update docs/_articles/en/einstein/einstein-example-prompts.md

Co-authored-by: Martha Morgan <mmorgan@salesforce.com>

* Update docs/_articles/en/einstein/einstein-example-prompts.md

Co-authored-by: Martha Morgan <mmorgan@salesforce.com>

* Update docs/_articles/en/einstein/einstein-example-prompts.md

Co-authored-by: Martha Morgan <mmorgan@salesforce.com>

* Update docs/_articles/en/einstein/einstein-example-prompts.md

Co-authored-by: Martha Morgan <mmorgan@salesforce.com>

* Update docs/_articles/en/einstein/einstein-example-prompts.md

Co-authored-by: Martha Morgan <mmorgan@salesforce.com>

* Update docs/_articles/en/einstein/einstein-faq.md

Co-authored-by: Martha Morgan <mmorgan@salesforce.com>

* Update docs/_articles/en/einstein/einstein-faq.md

Co-authored-by: Martha Morgan <mmorgan@salesforce.com>

* Update docs/_articles/en/einstein/einstein-glossary.md

Co-authored-by: Martha Morgan <mmorgan@salesforce.com>

* Update docs/_articles/en/einstein/einstein-faq.md

Co-authored-by: Martha Morgan <mmorgan@salesforce.com>

* Update docs/_articles/en/einstein/einstein-faq.md

Co-authored-by: Martha Morgan <mmorgan@salesforce.com>

* Update docs/_articles/en/einstein/einstein-faq.md

Co-authored-by: Martha Morgan <mmorgan@salesforce.com>

* Update docs/_articles/en/einstein/einstein-example-prompts.md

Co-authored-by: Martha Morgan <mmorgan@salesforce.com>

* Update docs/_articles/en/einstein/einstein-apex.md

Co-authored-by: Martha Morgan <mmorgan@salesforce.com>

* Update docs/_articles/en/einstein/einstein-example-prompts.md

Co-authored-by: Martha Morgan <mmorgan@salesforce.com>

* Update docs/_articles/en/einstein/einstein-example-prompts.md

Co-authored-by: Martha Morgan <mmorgan@salesforce.com>

* Update docs/_articles/en/einstein/einstein-example-prompts.md

Co-authored-by: Martha Morgan <mmorgan@salesforce.com>

* Update docs/_articles/en/einstein/einstein-apex.md

Co-authored-by: Martha Morgan <mmorgan@salesforce.com>

* Update docs/_articles/en/einstein/einstein-apex.md

Co-authored-by: Martha Morgan <mmorgan@salesforce.com>

* Update docs/_articles/en/einstein/einstein-glossary.md

Co-authored-by: Martha Morgan <mmorgan@salesforce.com>

* Update docs/_articles/en/einstein/einstein-glossary.md

Co-authored-by: Martha Morgan <mmorgan@salesforce.com>

* Update docs/_articles/en/einstein/einstein-glossary.md

Co-authored-by: Martha Morgan <mmorgan@salesforce.com>

* Update docs/_articles/en/einstein/einstein-glossary.md

Co-authored-by: Martha Morgan <mmorgan@salesforce.com>

* Update docs/_articles/en/einstein/einstein-glossary.md

Co-authored-by: Martha Morgan <mmorgan@salesforce.com>

* Update docs/_articles/en/einstein/einstein-glossary.md

Co-authored-by: Martha Morgan <mmorgan@salesforce.com>

* Update docs/_articles/en/einstein/einstein-overview.md

Co-authored-by: Martha Morgan <mmorgan@salesforce.com>

* Update docs/_articles/en/einstein/einstein-overview.md

Co-authored-by: Martha Morgan <mmorgan@salesforce.com>

* Update docs/_articles/en/einstein/einstein-overview.md

Co-authored-by: Martha Morgan <mmorgan@salesforce.com>

* Update docs/_articles/en/einstein/einstein-overview.md

Co-authored-by: Martha Morgan <mmorgan@salesforce.com>

* Update docs/_articles/en/einstein/einstein-overview.md

Co-authored-by: Martha Morgan <mmorgan@salesforce.com>

* Update docs/_articles/en/einstein/einstein-overview.md

Co-authored-by: Martha Morgan <mmorgan@salesforce.com>

* Update docs/_articles/en/einstein/einstein-overview.md

Co-authored-by: Martha Morgan <mmorgan@salesforce.com>

* Update docs/_articles/en/einstein/einstein-overview.md

Co-authored-by: Martha Morgan <mmorgan@salesforce.com>

* Update docs/_articles/en/einstein/einstein-setup.md

Co-authored-by: Martha Morgan <mmorgan@salesforce.com>

* Update docs/_articles/en/einstein/einstein-glossary.md

Co-authored-by: Martha Morgan <mmorgan@salesforce.com>

* Update docs/_articles/en/einstein/einstein-overview.md

Co-authored-by: Martha Morgan <mmorgan@salesforce.com>

* Update docs/_articles/en/einstein/einstein-overview.md

Co-authored-by: Martha Morgan <mmorgan@salesforce.com>

* Update docs/_articles/en/einstein/einstein-overview.md

Co-authored-by: Martha Morgan <mmorgan@salesforce.com>

* Update docs/_articles/en/einstein/einstein-setup.md

Co-authored-by: Martha Morgan <mmorgan@salesforce.com>

* Update docs/_articles/en/einstein/einstein-glossary.md

Co-authored-by: Martha Morgan <mmorgan@salesforce.com>

* Update docs/_articles/en/einstein/einstein-overview.md

Co-authored-by: Martha Morgan <mmorgan@salesforce.com>

* Update einstein-example-prompts.md

* Update docs/_articles/en/einstein/einstein-setup.md

Co-authored-by: Martha Morgan <mmorgan@salesforce.com>

* Update docs/_articles/en/einstein/einstein-setup.md

Co-authored-by: Martha Morgan <mmorgan@salesforce.com>

* Update docs/_articles/en/einstein/einstein-setup.md

Co-authored-by: Martha Morgan <mmorgan@salesforce.com>

* Update docs/_articles/en/einstein/einstein-setup.md

Co-authored-by: Martha Morgan <mmorgan@salesforce.com>

* Update docs/_articles/en/einstein/einstein-setup.md

Co-authored-by: Martha Morgan <mmorgan@salesforce.com>

* Update docs/_articles/en/einstein/einstein-setup.md

Co-authored-by: Martha Morgan <mmorgan@salesforce.com>

* Update docs/_articles/en/einstein/einstein-setup.md

Co-authored-by: Martha Morgan <mmorgan@salesforce.com>

* Update docs/_articles/en/einstein/einstein-setup.md

Co-authored-by: Martha Morgan <mmorgan@salesforce.com>

* Update docs/_articles/en/einstein/einstein-overview.md

Co-authored-by: Martha Morgan <mmorgan@salesforce.com>

* Update einstein-apex.md

* Update einstein-example-prompts.md

* Update einstein-glossary.md

* Update einstein-glossary.md

* Update einstein-setup.md

* Update einstein-overview.md

* Update einstein-overview.md

---------

Co-authored-by: AnanyaJha <a.jha@salesforce.com>
Co-authored-by: Martha Morgan <mmorgan@salesforce.com>
@peternhale peternhale requested a review from a team as a code owner September 8, 2023 11:26
daphne-sfdc
daphne-sfdc approved these changes Sep 18, 2023
View reviewed changes
Copy link
Contributor

@daphne-sfdc daphne-sfdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! 🎉

@peternhale peternhale merged commit 5f44746 into develop Sep 19, 2023
16 checks passed
@peternhale peternhale deleted the phale/remove-java-8 branch September 19, 2023 17:53
@daphne-sfdc
Copy link
Contributor

daphne-sfdc commented Sep 21, 2023 •
edited

Here are the steps I took to make sure the code changes in this PR correctly removed support for Java 8:

  1. The integration test “vscode-integration/requirements.test.ts” was modified to test that Java 8 should NOT be supported. Run this integration test locally and make sure it passes. ✅

  2. Download and install Zulu Java 8 on my computer.

  3. Go to VSCode User Settings and set Java Home to the path of the Java 8.

  4. In the “Run and Debug” tab on the sidebar, run “Launch Extensions”.

  5. In the window that pops up, run “SFDX: Create Project” in the command palette.

  6. I found this notification: ✅

Screenshot 2023-09-21 at 9 58 19 AM
  1. Run “SFDX: Create Apex Class” in the command palette.
  2. Make sure Intellisense does not work in the newly created Apex class. ✅

Both the integration test and my manual testing show that Java 8 is no longer compatible with the Apex LSP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daphne-sfdc daphne-sfdc daphne-sfdc approved these changes

@RitamAgrawal RitamAgrawal Awaiting requested review from RitamAgrawal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@peternhale @daphne-sfdc @RitamAgrawal @sbudhirajadoc