feat: upgrade to node18 #5155
feat: upgrade to node18 #5155
Conversation
There was a problem hiding this comment.
@gbockus-sf I posted a number questions. Looks good overall, I will try to test tomorrow morning, if that is ok.
packages/salesforcedx-apex-debugger/test/unit/core/breakpointService.test.ts
Show resolved
Hide resolved
| @@ -45,7 +45,7 @@ | |||
| "watch": "tsc -watch -p .", | |||
| "clean": "shx rm -rf node_modules && shx rm -rf out && shx rm -rf coverage && shx rm -rf .nyc_output", | |||
| "test": "npm run test:unit && npm run test:integration", | |||
| "test:unit": "jest --coverage", | |||
| "test:unit": "jest --coverage --forceExit", | |||
There was a problem hiding this comment.
Is this the permanent solution?
| @@ -7,7 +7,7 @@ | |||
|
|
|||
| // tslint:disable-next-line:no-var-requires | |||
There was a problem hiding this comment.
Can the tslint annotations be removed
| @@ -23,16 +23,16 @@ | |||
| "@salesforce/ts-sinon": "1.4.0", | |||
| "@types/chai": "4.3.3", | |||
| "@types/cross-spawn": "6.0.0", | |||
| "@types/jest": "28.1.7", | |||
| "@types/jest": "28.1.1", | |||
There was a problem hiding this comment.
There is a v29* version of this module. Upgrade this with jest?
There was a problem hiding this comment.
I'll ensure the jest & @types/jest are all aligned
packages/salesforcedx-utils-vscode/test/unit/commands/channelService.test.ts
Show resolved
Hide resolved
| this.timeout(10000); | ||
| await coreExtension.activate(); | ||
| expect(coreExtension.isActive); | ||
| }); | ||
|
|
||
| it('aura activation', async function() { | ||
| // tslint:disable-next-line:no-invalid-this | ||
| this.timeout(10000); |
There was a problem hiding this comment.
You could try it('foo bar baz).timeout(10000);
There was a problem hiding this comment.
interesting. Didn't know that was a thing. I'll give it a shot
There was a problem hiding this comment.
Configuring the type for this seems like the right path for these weird mocha tests.
There was a problem hiding this comment.
@gbockus-sf the timeout goes on the it not the expect
it('foo bar`, () => {
expect(....);
}).timeout(10000);
|
Did some initial testing on the vsix builds. I see a couple of issues with the LWC & lighting language servers. Will see what I can do to remedy this evening |
|
FYI @peternhale ☝️ |
| "aura-language-server", | ||
| "lib", | ||
| "server.js" | ||
| ], |
There was a problem hiding this comment.
So the deal here is the server file lives in the root node_modules directory when running in debug mode as part of the monorepo, but lives in the extension level node_module directory when running as a vsix. I updated both the lightning and lwc extension to account for that change as part of the packaging. Part of this is updating where each extension gets the path to the server to follow the same pattern we see in other extensions.
|
vsix issue with the lightning/lwc lsp resolved with commit 16fa698 |
…dotcom/salesforcedx-vscode into gbockus/W-13209367-upgrade-node-18
…dotcom/salesforcedx-vscode into gbockus/W-13209367-upgrade-node-18
What does this PR do?
Upgrade the version of node used for development to Node 18.
It's a Tangled web we weave.
This PR does the following:
What issues does this PR fix or reference?
Note the node18 upgrade was broken into several tickets
@W-13209367@
@W-14196469@
@W-14196410@
@W-14196482@
@W-14196589@
Notes
For testing this change ensure that you are on node 18 and npm 9.8
My sure fire way to get everything to build happily is to follow the following steps:
#success