fix: add missing label #5162
Merged
fix: add missing label #5162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peternhale
approved these changes
Oct 17, 2023
|
@gbockus-sf how is this change tested? can automation be added for this? |
|
@diyer This is an odd corner case as it's only exposed when an external extension calls a command in our extension. This is fairly unusal (currently anyway). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
CodeBuilder found a flow where we had a missing label. I verified by altering the local code to always print the label and found it was indeed missing from the core extension.
What issues does this PR fix or reference?
@W-14284449@
#5156
Functionality Before
Functionality After